Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests requires matplotlib #530

Closed
rth opened this issue Sep 18, 2018 · 2 comments
Closed

Running tests requires matplotlib #530

rth opened this issue Sep 18, 2018 · 2 comments
Labels
Good First Issue Issues suitable for people new to contributing to openml-python!

Comments

@rth
Copy link
Contributor

rth commented Sep 18, 2018

As part of pytest migration in #527, it looks like matplotlib is hard dependency for running tests, despite what setup.py requirements, and CONTRIBUTING.md says.

It is imported in

but doesn't seem to be used (added in #430).

Is it required by nbformat?

An alternative could be to skip corresponding tests.

@mfeurer
Copy link
Collaborator

mfeurer commented Sep 20, 2018

We used to have a jupyter notebook as an example which used matplotlib. In the last few weeks, we replaced it by multiple small python examples and removed the plotting for the moment. The notebook was unit tested, and I guess we can remove that unit test for now. Do you want to create a PR for this?

@mfeurer mfeurer added the Good First Issue Issues suitable for people new to contributing to openml-python! label Jan 15, 2019
@PGijsbers
Copy link
Collaborator

With many issues open on the same topic, I decided to close this one. All further discussion can be had in #596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Issues suitable for people new to contributing to openml-python!
Projects
None yet
Development

No branches or pull requests

3 participants