Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CPU-only builds #48

Merged
merged 10 commits into from
Dec 23, 2021
Merged

Enable CPU-only builds #48

merged 10 commits into from
Dec 23, 2021

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Dec 20, 2021 •
edited
Loading

  • Add ENABLE_CUDA option
  • Conditionally build the library and PyTorch wrappers
  • Update CI

Needed by #26 (comment)

@raimis raimis self-assigned this Dec 20, 2021
@raimis raimis added this to Regular in Accelerated NNP in OpenMM via automation Dec 20, 2021
@raimis raimis marked this pull request as ready for review December 20, 2021 15:02
@raimis raimis requested a review from peastman December 20, 2021 15:03
@raimis
Copy link
Contributor Author

raimis commented Dec 20, 2021

@peastman could you review?

@raimis raimis mentioned this pull request Dec 20, 2021
Closed
@raimis raimis moved this from Regular to Blockers in Accelerated NNP in OpenMM Dec 20, 2021
peastman
peastman approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@raimis raimis merged commit 37a8606 into openmm:master Dec 23, 2021
Accelerated NNP in OpenMM automation moved this from Blockers to Done Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peastman peastman peastman approved these changes

Assignees

@raimis raimis

Labels
None yet
Projects
Accelerated NNP in OpenMM
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raimis @peastman