Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tutorial #77

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Fix the tutorial #77

merged 4 commits into from
Jun 10, 2022

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Jun 3, 2022 •
edited
Loading

  • Explicitly install Miniconda
  • Update dependencies

@raimis raimis self-assigned this Jun 3, 2022
@raimis raimis added this to Regular in Accelerated NNP in OpenMM via automation Jun 3, 2022
@raimis
Copy link
Contributor Author

raimis commented Jun 3, 2022

Fixing RPATH (conda-forge/openmm-torch-feedstock#18)

@raimis raimis mentioned this pull request Jun 3, 2022
Open
@raimis raimis changed the title Fit the tutorial Fix the tutorial Jun 3, 2022
@raimis raimis marked this pull request as ready for review June 8, 2022 10:57
@raimis raimis requested a review from peastman June 8, 2022 10:58
@raimis
Copy link
Contributor Author

raimis commented Jun 8, 2022

@peastman could you review?

peastman
peastman approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but everything looks reasonable. As long as it works, I don't have any changes to suggest.

@raimis raimis merged commit 25fad7f into openmm:master Jun 10, 2022
Accelerated NNP in OpenMM automation moved this from Regular to Done Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peastman peastman peastman approved these changes

Assignees

@raimis raimis

Labels
None yet
Projects
Accelerated NNP in OpenMM
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raimis @peastman