Use command line compiler if it is explicitly specified #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run jenkins |
|
@swails Jenkins is failing to start up: |
I was bringing another agent into the Jenkins array that needed to be rebooted. The PR job has now passed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.5 we changed the behavior of compiling CUDA kernels, so it would prefer the runtime compiler over the command line compiler. This was supposed to avoid problems, but it ended up creating some new problems. One of them is that if anything went wrong with the runtime compiler, it was hard to fix. There was no straightforward way to force it to use the command line compiler instead.
This PR changes the behavior so that if you explicitly specify a command line compiler, either with the
'CudaCompiler'property or theOPENMM_CUDA_COMPILERenvironment variable, that forces it to use the compiler you specify. It will never use the runtime compiler instead.