Fix PSF setBox function for Triclinic case #3072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing a PDB generated from some CHARMM files earlier, I noticed that the unitcell was orthorhombic even after setting a triclinic box up via the
setBox
function. Unless I'm misunderstanding, the problem is that the orthorhombicsetUnitCellDimensions
was being called on the underlying topology object so I switched it. The test case in this PR provides a MWE.