Storage sdk: Remove parentId as paramater.

openmobilehub · Jul 4, 2023 · c5aa49b · c5aa49b
1 parent 8e36773
commit c5aa49b
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 17 deletions.
diff --git a/.../main/java/com/omh/android/storage/api/drive/gms/data/repository/GmsFileRepositoryImpl.kt b/.../main/java/com/omh/android/storage/api/drive/gms/data/repository/GmsFileRepositoryImpl.kt
@@ -23,5 +23,5 @@ internal class GmsFileRepositoryImpl(
 
     override fun open() = Unit
 
-    override fun updateFile(localFileToUpload: File, fileId: String, parentId: String?) = null
+    override fun updateFile(localFileToUpload: File, fileId: String) = null
 }
diff --git a/...ain/java/com/omh/android/storage/api/drive/gms/data/source/GmsFileRemoteDataSourceImpl.kt b/...ain/java/com/omh/android/storage/api/drive/gms/data/source/GmsFileRemoteDataSourceImpl.kt
@@ -68,7 +68,7 @@ internal class GmsFileRemoteDataSourceImpl(private val apiService: GoogleDriveAp
         return response.toOmhFile()
     }
 
-    override fun updateFile(localFileToUpload: File, fileId: String, parentId: String?) = null
+    override fun updateFile(localFileToUpload: File, fileId: String) = null
 
     private fun getStringMimeTypeFromLocalFile(file: File) = MimeTypeMap
         .getSingleton()

diff --git a/...java/com/omh/android/storage/api/drive/nongms/data/repository/NonGmsFileRepositoryImpl.kt b/...java/com/omh/android/storage/api/drive/nongms/data/repository/NonGmsFileRepositoryImpl.kt
@@ -24,6 +24,6 @@ internal class NonGmsFileRepositoryImpl(
 
     override fun open() = Unit
 
-    override fun updateFile(localFileToUpload: File, fileId: String, parentId: String?) =
-        dataSource.updateFile(localFileToUpload, fileId, parentId)
+    override fun updateFile(localFileToUpload: File, fileId: String) =
+        dataSource.updateFile(localFileToUpload, fileId)
 }
diff --git a/...va/com/omh/android/storage/api/drive/nongms/data/source/NonGmsFileRemoteDataSourceImpl.kt b/...va/com/omh/android/storage/api/drive/nongms/data/source/NonGmsFileRemoteDataSourceImpl.kt
@@ -155,12 +155,10 @@ internal class NonGmsFileRemoteDataSourceImpl(private val retrofitImpl: GoogleRe
     }
     override fun updateFile(
         localFileToUpload: File,
-        fileId: String,
-        parentId: String?
+        fileId: String
     ): OmhFile? {
         val jsonMetaData = JSONObject().apply {
             put(FILE_NAME_KEY, localFileToUpload.name)
-            put(FILE_PARENTS_KEY, parentId.isNullOrBlank())
         }
 
         val jsonRequestBody = jsonMetaData.toString().toRequestBody(JSON_MIME_TYPE)

diff --git a/storage-api/src/main/java/com/omh/android/storage/api/OmhStorageClient.kt b/storage-api/src/main/java/com/omh/android/storage/api/OmhStorageClient.kt
@@ -88,14 +88,10 @@ abstract class OmhStorageClient protected constructor(
         }
     }
 
-    fun updateFile(
-        localFileToUpload: File,
-        fileId: String,
-        parentId: String?
-    ): OmhTask<UpdateFileUseCaseResult> {
+    fun updateFile(localFileToUpload: File, fileId: String): OmhTask<UpdateFileUseCaseResult> {
         val updateFileUseCase = UpdateFileUseCase(getRepository())
         return OmhStorageTaskImpl {
-            val parameters = UpdateFileUseCaseParams(localFileToUpload, fileId, parentId)
+            val parameters = UpdateFileUseCaseParams(localFileToUpload, fileId)
             val result = updateFileUseCase(parameters)
             result
         }

diff --git a/storage-api/src/main/java/com/omh/android/storage/api/data/source/OmhFileRemoteDataSource.kt b/storage-api/src/main/java/com/omh/android/storage/api/data/source/OmhFileRemoteDataSource.kt
@@ -19,5 +19,5 @@ interface OmhFileRemoteDataSource {
 
     fun downloadFile(fileId: String, mimeType: String?): ByteArrayOutputStream
 
-    fun updateFile(localFileToUpload: File, fileId: String, parentId: String?): OmhFile?
+    fun updateFile(localFileToUpload: File, fileId: String): OmhFile?
 }
diff --git a/storage-api/src/main/java/com/omh/android/storage/api/domain/repository/OmhFileRepository.kt b/storage-api/src/main/java/com/omh/android/storage/api/domain/repository/OmhFileRepository.kt
@@ -18,5 +18,5 @@ interface OmhFileRepository {
 
     fun open()
 
-    fun updateFile(localFileToUpload: File, fileId: String, parentId: String?): OmhFile?
+    fun updateFile(localFileToUpload: File, fileId: String): OmhFile?
 }
diff --git a/storage-api/src/main/java/com/omh/android/storage/api/domain/usecase/UpdateFileUseCase.kt b/storage-api/src/main/java/com/omh/android/storage/api/domain/usecase/UpdateFileUseCase.kt
@@ -13,11 +13,11 @@ class UpdateFileUseCase(
 
     override suspend fun execute(parameters: UpdateFileUseCaseParams): UpdateFileUseCaseResult {
         return UpdateFileUseCaseResult(
-            repository.updateFile(parameters.localFileToUpdate, parameters.fileId, parameters.parentId)
+            repository.updateFile(parameters.localFileToUpdate, parameters.fileId)
         )
     }
 }
 
-data class UpdateFileUseCaseParams(val localFileToUpdate: File, val fileId: String, val parentId: String?)
+data class UpdateFileUseCaseParams(val localFileToUpdate: File, val fileId: String)
 
 data class UpdateFileUseCaseResult(val file: OmhFile?)