Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Branch Name and Github Workflow Badge Colors #107

Closed
3 tasks done
dzuluaga opened this issue Jul 31, 2023 · 5 comments
Closed
3 tasks done

Incorrect Branch Name and Github Workflow Badge Colors #107

dzuluaga opened this issue Jul 31, 2023 · 5 comments
Assignees
Labels
bug Something isn't working code-starter documentation Improvements or additions to documentation

Comments

@dzuluaga
Copy link
Collaborator

dzuluaga commented Jul 31, 2023

Currently, the README file contains an invalid branch name in the git clone command, and the Github workflow badges appear in the wrong color. This issue aims to address both of these problems.

Action Items:

  1. Invalid Branch Name in README git clone Command

The current command in the README for cloning the repository using the starter-code branch is incorrect. The starter-code branch is not available in the upstream origin, leading to a fatal error during cloning.

Proposed Solution:
Update the command in the README to use the correct branch name code-starter for cloning the repository.

Incorrect Command:

git clone --branch starter-code https://github.com/openmobilehub/omh-storage.git omh-storage-starter-code

Corrected Command:

git clone --branch code-starter https://github.com/openmobilehub/omh-storage.git omh-storage-starter-code
  1. Github Workflow Badge Colors

The Github workflow badges currently display in gray, which might indicate that the workflows are not successful or not being tested. These badges should show up in green for better visibility and clarity.

Proposed Solution:
Ensure that the build scripts for the workflows are tested and working correctly, so the badges appear in green.

  1. Test the Build Scripts for Github Workflows
  • Test the build script for the "Publish Storage API" workflow.
  • Test the build script for the "Publish Storage API Google Drive Implementation" workflow.
  • Test the build script for the "Publish Storage API NonGMS Implementation" workflow.

Upon successful testing, the badges should update to show a green status for each workflow.

Additional Information:

@dzuluaga dzuluaga added bug Something isn't working documentation Improvements or additions to documentation code-starter labels Jul 31, 2023
@HectorNarvaez
Copy link
Contributor

PR for item # 1: #113

Regarding to items # 2 and # 3, i suggest you to check with someone with knowledge in Github Workflows, for example someone specialized in DevOps. As android developer, those items are out of my scope.

c.c.: @dzuluaga @mariomonteroencora @teban1288 @nelsonwilches

@HectorNarvaez
Copy link
Contributor

PR merged

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 7, 2023

Badges are in red due to #127. PTAL. Thanks.

@HectorNarvaez
Copy link
Contributor

comment answered:

#127 (comment)

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 8, 2023

LGTM. Thx

@dzuluaga dzuluaga closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code-starter documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants