Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing local.properties Step in GitHub Actions Workflows #127

Closed
dzuluaga opened this issue Aug 7, 2023 · 8 comments
Closed

Missing local.properties Step in GitHub Actions Workflows #127

dzuluaga opened this issue Aug 7, 2023 · 8 comments
Assignees

Comments

@dzuluaga
Copy link
Collaborator

dzuluaga commented Aug 7, 2023

GitHub Actions workflows for OMH Storage API, OMH Storage API Drive GMS Implementation, and OMH Storage API Drive non-GMS Implementation are failing due to the absence of the local.properties setup step in the workflow YAML files. This step is essential for configuring environment variables and SDK paths.

Proposed Solution:

Add the necessary step to set up the local.properties file in the workflow YAML files to resolve the build failures.

Reference Run:
GitHub Actions Run

Please address this issue promptly to enable successful builds and contributions. Feel free to reach out for any additional information.

@HectorNarvaez
Copy link
Contributor

You can check this with someone with knowledge in DevOps.

As Android developer, this is out of my scope.

c.c.: @nelsonwilches @dzuluaga @mariomonteroencora @teban1288

@HectorNarvaez
Copy link
Contributor

I'll redirect this to @nelsonwilches for validate who will work on this

c.c.: @dzuluaga @teban1288 @mariomonteroencora

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 8, 2023

It's a couple of line of code. Could you take a look at how the OMH Maps does it? Thanks

@HectorNarvaez
Copy link
Contributor

Currently, github actions on storage are basically a copy-paste of the ones defined on auth and maps. The only difference is the one done due to issue #97 (PR #102)

Far away from that, i don't have knowledge about CI. So, @nelsonwilches will redirect this to an appropiate person.

c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 8, 2023

Okay. But, for the record, you're already doing it on the on_pull_request.yml. It's just missing in the other yml files.

@HectorNarvaez
Copy link
Contributor

Checked this with @hans-hamel and opened a PR: #130

Once merged, please let us know if this solves the issue

@HectorNarvaez
Copy link
Contributor

PR merged

c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288

@dzuluaga
Copy link
Collaborator Author

dzuluaga commented Aug 8, 2023

It works. Thanks!

@dzuluaga dzuluaga closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants