-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Source Code Linking Ability to OMH Storage AAR - OUT-OF-SCOPE #153
Comments
Hi Diego Unfortunately now this is out of our scope. As discussed with @nelsonwilches, the last issue we where able to solve was #147 Not sure who would be the indicated person for discuss about this, but feel free to reach @nelsonwilches, @mariomonteroencora or @teban1288 for more information about this |
PR for update base lib on auth |
PR for update auth version for modules gms, non-gms and api |
auth api non-gms v1.0.1-beta-> deployed on nexus ✅ |
PR for update auth sample app |
Auth updated ✅ |
Thanks, @HectorNarvaez. Can you please ensure also README.md and all files point to the latest version? Thanks! |
PR for update auth version on storage #157 |
PR for update base lib on storage #158 |
PR for update library versions #159 |
storage api non-gms v1.0.8-beta -> deployed on nexus ✅ |
PR for update library versions on sample app #160 |
PR opened for #153 (comment) |
All changes for auth done ✅ All changes are on branch c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288 |
PR for storage related to #153 (comment) |
All changes for storage done ✅ All changes are on branch c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288 |
@hans-hamel can you please comment here the changes done for maps? For have a clearer tracking about the actions done for solve this issue. Thanks! |
Thanks @HectorNarvaez. Did you or the team get a chance to test these changes? If so, do you mind releasing them from staging? Thanks |
we tested it from development side. @neiger can you please help us with the QA tests? thanks! |
@HectorNarvaez I did a smoke testing on the sample app and it looks good to me. |
@dzuluaga QA tested completed ✅ Feel free to promote the artifacts from staging to prod |
LGTM. Merged to main. |
The current version of OMH Storage AAR lacks the ability to link the -sources.jar file with the byte code in the library. This omission prevents developers from easily navigating through the OMH source code during development and debugging. Unlike some other popular client libraries like androidx and retrofit, where source code linking is a common and beneficial feature, the absence of this capability in OMH Storage hinders efficient development and debugging workflows.
Proposed Enhancement:
It would be highly beneficial to include the ability to link the OMH Storage AAR with the corresponding -sources.jar file generated during library assembly. This enhancement would empower developers to:
Benefits:
By incorporating source code linking, OMH Storage can align with industry best practices and enhance its usability for developers. This enhancement would foster a more efficient development process, streamline debugging efforts, and ultimately contribute to a smoother integration of OMH Storage into various projects.
Comparison to Other Libraries:
Many well-established libraries like androidx and retrofit have successfully integrated source code linking as a standard feature. This approach has been recognized as a best practice within the development community. Incorporating a similar feature in OMH Storage would not only bring it in line with these established practices but also make it more attractive to potential users.
Thanks for considering this request.
Diego
The text was updated successfully, but these errors were encountered: