Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Source Code Linking Ability to OMH Storage AAR - OUT-OF-SCOPE #153

Closed
dzuluaga opened this issue Aug 15, 2023 · 22 comments
Closed

Add Source Code Linking Ability to OMH Storage AAR - OUT-OF-SCOPE #153

dzuluaga opened this issue Aug 15, 2023 · 22 comments
Assignees

Comments

@dzuluaga
Copy link
Collaborator

The current version of OMH Storage AAR lacks the ability to link the -sources.jar file with the byte code in the library. This omission prevents developers from easily navigating through the OMH source code during development and debugging. Unlike some other popular client libraries like androidx and retrofit, where source code linking is a common and beneficial feature, the absence of this capability in OMH Storage hinders efficient development and debugging workflows.

Proposed Enhancement:
It would be highly beneficial to include the ability to link the OMH Storage AAR with the corresponding -sources.jar file generated during library assembly. This enhancement would empower developers to:

  1. Navigate seamlessly through the OMH source code while working on their projects.
  2. Set breakpoints and inspect code behavior during debugging sessions without requiring manual setup steps.
  3. Improve the overall development experience and productivity when integrating OMH Storage into projects.

Benefits:
By incorporating source code linking, OMH Storage can align with industry best practices and enhance its usability for developers. This enhancement would foster a more efficient development process, streamline debugging efforts, and ultimately contribute to a smoother integration of OMH Storage into various projects.

Comparison to Other Libraries:
Many well-established libraries like androidx and retrofit have successfully integrated source code linking as a standard feature. This approach has been recognized as a best practice within the development community. Incorporating a similar feature in OMH Storage would not only bring it in line with these established practices but also make it more attractive to potential users.

Thanks for considering this request.
Diego

@HectorNarvaez
Copy link
Contributor

Hi Diego

Unfortunately now this is out of our scope. As discussed with @nelsonwilches, the last issue we where able to solve was #147

Not sure who would be the indicated person for discuss about this, but feel free to reach @nelsonwilches, @mariomonteroencora or @teban1288 for more information about this

@dzuluaga dzuluaga changed the title Add Source Code Linking Ability to OMH Storage AAR Add Source Code Linking Ability to OMH Storage AAR - OUT-OF-SCOPE Aug 16, 2023
@HectorNarvaez
Copy link
Contributor

HectorNarvaez commented Aug 22, 2023

PR for update base lib on auth

106

@HectorNarvaez
Copy link
Contributor

HectorNarvaez commented Aug 22, 2023

PR for update auth version for modules gms, non-gms and api

107

@HectorNarvaez
Copy link
Contributor

auth api non-gms v1.0.1-beta-> deployed on nexus ✅
auth api gms v1.0.1-beta -> deployed on nexus ✅
auth api v1.0.1-beta -> deployed on nexus ✅

@HectorNarvaez
Copy link
Contributor

PR for update auth sample app

108

@HectorNarvaez
Copy link
Contributor

Auth updated ✅

@dzuluaga
Copy link
Collaborator Author

Thanks, @HectorNarvaez. Can you please ensure also README.md and all files point to the latest version? Thanks!

@HectorNarvaez
Copy link
Contributor

PR for update auth version on storage #157

@HectorNarvaez
Copy link
Contributor

PR for update base lib on storage #158

@HectorNarvaez
Copy link
Contributor

PR for update library versions #159

@HectorNarvaez
Copy link
Contributor

storage api non-gms v1.0.8-beta -> deployed on nexus ✅
storage api gms v1.0.7-beta -> deployed on nexus ✅
storage api v1.0.5-beta -> deployed on nexus ✅

@HectorNarvaez
Copy link
Contributor

PR for update library versions on sample app #160

@HectorNarvaez
Copy link
Contributor

PR opened for #153 (comment)

openmobilehub/omh-auth#109

@HectorNarvaez
Copy link
Contributor

All changes for auth done ✅

All changes are on branch 1.0.1-beta

c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288

@HectorNarvaez
Copy link
Contributor

PR for storage related to #153 (comment)

#161

@HectorNarvaez
Copy link
Contributor

All changes for storage done ✅

All changes are on branch release/1.0

c.c.: @dzuluaga @nelsonwilches @mariomonteroencora @teban1288

@HectorNarvaez
Copy link
Contributor

@hans-hamel can you please comment here the changes done for maps? For have a clearer tracking about the actions done for solve this issue.

Thanks!

@dzuluaga
Copy link
Collaborator Author

Thanks @HectorNarvaez. Did you or the team get a chance to test these changes? If so, do you mind releasing them from staging? Thanks

@HectorNarvaez
Copy link
Contributor

we tested it from development side. @neiger can you please help us with the QA tests? thanks!

@neiger
Copy link
Contributor

neiger commented Aug 24, 2023

@HectorNarvaez I did a smoke testing on the sample app and it looks good to me.

@HectorNarvaez
Copy link
Contributor

@dzuluaga QA tested completed ✅

Feel free to promote the artifacts from staging to prod

c.c.: @nelsonwilches @mariomonteroencora @teban1288

@dzuluaga
Copy link
Collaborator Author

LGTM. Merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants