Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make list files generic #19

Merged
merged 1 commit into from
May 31, 2023
Merged

Make list files generic #19

merged 1 commit into from
May 31, 2023

Conversation

HectorNarvaez
Copy link
Contributor

Make get root files list generic for list files in any folder with parent id

This PR depends on #18, and can see easy diff clicking here.

@HectorNarvaez HectorNarvaez added Don't merge Can't be merged yet Depends on This have dependency with another PR labels May 29, 2023
@HectorNarvaez HectorNarvaez mentioned this pull request May 30, 2023
Merged
@HectorNarvaez HectorNarvaez removed Don't merge Can't be merged yet Depends on This have dependency with another PR labels May 30, 2023
Anwera64
Anwera64 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just take into mind what we talked about coroutine dispatchers in the repositories instead of the use case

@HectorNarvaez HectorNarvaez merged commit 587bf7c into develop May 31, 2023
2 checks passed
@HectorNarvaez HectorNarvaez deleted the state/makeListFilesGeneric branch May 31, 2023 15:10
@HectorNarvaez HectorNarvaez mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anwera64 Anwera64 Anwera64 approved these changes

@hans-hamel hans-hamel hans-hamel approved these changes

@wilsoncastiblanco wilsoncastiblanco Awaiting requested review from wilsoncastiblanco

@jdiegoh3 jdiegoh3 Awaiting requested review from jdiegoh3

@bardur-encora bardur-encora Awaiting requested review from bardur-encora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HectorNarvaez @Anwera64 @hans-hamel