Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor grid adapter #22

Merged
merged 2 commits into from
May 31, 2023
Merged

Refactor grid adapter #22

merged 2 commits into from
May 31, 2023

Conversation

HectorNarvaez
Copy link
Contributor

Refactor FileGridAdapter for:

  • Extend from ListAdapter
  • Implement click listener
  • Implement diff callback
  • Improve bind method on FileGridViewHolder

Anwera64
Anwera64 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HectorNarvaez HectorNarvaez merged commit 8d0f4d1 into develop May 31, 2023
2 checks passed
@HectorNarvaez HectorNarvaez deleted the state/refactorGridAdapter branch May 31, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anwera64 Anwera64 Anwera64 approved these changes

@wilsoncastiblanco wilsoncastiblanco Awaiting requested review from wilsoncastiblanco

@jdiegoh3 jdiegoh3 Awaiting requested review from jdiegoh3

@hans-hamel hans-hamel Awaiting requested review from hans-hamel

@bardur-encora bardur-encora Awaiting requested review from bardur-encora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HectorNarvaez @Anwera64