-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create file #29
Merged
Merged
Create file #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HectorNarvaez
added
Don't merge
Can't be merged yet
Depends on
This have dependency with another PR
labels
Jun 6, 2023
HectorNarvaez
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64,
hans-hamel and
bardur-encora
June 6, 2023 21:53
HectorNarvaez
removed
Don't merge
Can't be merged yet
Depends on
This have dependency with another PR
labels
Jun 6, 2023
… charge of create files
HectorNarvaez
force-pushed
the
state/createFile
branch
from
June 6, 2023 22:16
07149dc
to
942c96b
Compare
Merged
Anwera64
reviewed
Jun 7, 2023
storage-sample/src/main/java/com/omh/android/storage/sample/domain/model/FileType.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerActivity.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerActivity.kt
Outdated
Show resolved
Hide resolved
Anwera64
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of create files in any folder from the sample app. The files will be created on the current folder the user is located.
This PR depends on #28, and can see easy diff clicking here