Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename list files use case #31

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

HectorNarvaez
Copy link
Contributor

As the function for get the files list from remote will always receive the parent id, i decided to rename the class GetFilesListWithParentIdUseCase into GetFilesListUseCase. Is less verbose and have the same meaning.

This PR depends on #30, and can see easy diff clicking here

@HectorNarvaez HectorNarvaez added Don't merge Can't be merged yet Depends on This have dependency with another PR labels Jun 7, 2023
@HectorNarvaez HectorNarvaez force-pushed the state/renameListFilesUseCase branch 2 times, most recently from e213f9b to f5ea287 Compare June 7, 2023 22:04
@HectorNarvaez HectorNarvaez removed Don't merge Can't be merged yet Depends on This have dependency with another PR labels Jun 7, 2023
Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HectorNarvaez HectorNarvaez merged commit c93935a into develop Jun 8, 2023
4 checks passed
@HectorNarvaez HectorNarvaez deleted the state/renameListFilesUseCase branch June 8, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants