Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement non-gms upload #43

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Implement non-gms upload #43

merged 5 commits into from
Jun 21, 2023

Conversation

hans-hamel
Copy link
Collaborator

Implement upload a file in non-gms. the gms returns null and will be implemented in other task.

Copy link
Contributor

@HectorNarvaez HectorNarvaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments

Copy link
Contributor

@HectorNarvaez HectorNarvaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of comments

Copy link
Contributor

@HectorNarvaez HectorNarvaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HectorNarvaez HectorNarvaez added the Don't merge Can't be merged yet label Jun 21, 2023
@HectorNarvaez HectorNarvaez removed the Don't merge Can't be merged yet label Jun 21, 2023
@HectorNarvaez HectorNarvaez merged commit 3fe751d into develop Jun 21, 2023
2 checks passed
@HectorNarvaez HectorNarvaez deleted the feature/upload-non-gms branch June 21, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants