Add basic UI to download a file #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HectorNarvaez
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64,
bardur-encora and
HectorNarvaez
HectorNarvaez
added
Depends on
|
Is the "saving the file without an extension" functionality a responsibility of the library or of the sample app? |
Anwera64
reviewed
Jun 28, 2023
| } | ||
| } | ||
|
|
||
| if (deniedPermissions.isNotEmpty()) { |
There was a problem hiding this comment.
This could be an early return
There was a problem hiding this comment.
i think in this particular case an early return will not make difference
The result code would be something like:
if (deniedPermissions.isEmpty()) {
return
}
requestPermissions()
which is basically the same, but longer.
What do you think? @Anwera64
...src/main/java/com/omh/android/storage/sample/presentation/file_viewer/FileViewerViewModel.kt
Show resolved
Hide resolved
HectorNarvaez
force-pushed
the
state/gmsDownloadFile
branch
from
703e5dc
to
7256fda
Compare
HectorNarvaez
force-pushed
the
feature/download-ui
branch
from
09e0ab0
to
d5b1b27
Compare
This was referenced Jun 29, 2023
Closed
HectorNarvaez
force-pushed
the
feature/download-ui
branch
from
d5b1b27
to
546468d
Compare
HectorNarvaez
force-pushed
the
feature/download-ui
branch
from
4502676
to
a89e419
Compare
HectorNarvaez
removed
Don't merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on branch 'state/gmsDownloadFile'. After branch 'state/gmsDownloadFile' is merged, change this PR's base branch.
Basic UI. Requires to ask permissions dynamically. Not sure if try to save the file with a extension if it doesn't have a extension.
This PR depends on #50