Add empty view UI for no Files/Folders #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith auth integration(Non GMS)
nelsonfertica
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64 and
hans-hamel
|
Let us know when your CI is fixed to review this PR |
Anwera64
approved these changes
May 3, 2023
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| setContentView(ActivitySplashBinding.inflate(layoutInflater).root) | ||
| getToken() |
There was a problem hiding this comment.
you should actually check for the user. If there's a User then there's a token
HectorNarvaez
pushed a commit
that referenced
this pull request
May 16, 2023
* Add empty view if there are no files/folders, initial code to begin with auth integration(Non GMS) * Check directly for the user(therefore there's a token), remove extra code * Change method name from 'getToken' to 'checkUserThenNavigate' --------- Co-authored-by: Nelson Ivan Fernandez Suarez <nelson.fernandez@encora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add empty view UI if there are no files/folders, initial code to begin with auth integration(Non GMS)
emptyView.mov