Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop.rental_methods vs. fare_attributes.payment_type #844

Closed
thekaveman opened this issue Apr 23, 2023 · 6 comments
Closed

Stop.rental_methods vs. fare_attributes.payment_type #844

thekaveman opened this issue Apr 23, 2023 · 6 comments
Labels
Modes New modes that MDS can support (carshare, passenger services, delivery robots, etc) question Further information is requested Schema Implications for JSON Schema or OpenAPI
Milestone

Comments

@thekaveman
Copy link
Collaborator

Issue

Stops defines the rental_methods field as follows:

Enum[]: List of payment methods accepted at stop, see GBFS Rental Methods

GBFS Rental Methods as of April 2023 are:

  • key
  • creditcard
  • paypass
  • applepay
  • androidpay
  • transitcard
  • accountnumber
  • phone

Further, some modes support the fare_attributes.payment_type field, with a different list of options and the the following variation:

care-share delivery-robots passenger-services
cash x x x
credit_card x x
mobile x x x
voucher x x x
paratransit x x
no payment x x x
test x x x
@thekaveman thekaveman added the question Further information is requested label Apr 23, 2023
@schnuerle
Copy link
Member

Stops may be a bit of an outlier right now and should just stay aligned with GBFS and reference that externally.

For the modes, I think 1) paratransit needs to be removed from delivery robots, 2) credit_card added to delivery robots.

applepay vs androidpay is too specific a field for us in MDS land I think. But account_number and phone could be added to all modes, and then maybe mobile needs to be called mobile_app for clarity?

What are the values for micromobility?

@schnuerle schnuerle transferred this issue from openmobilityfoundation/mds-openapi Apr 24, 2023
@schnuerle schnuerle added Schema Implications for JSON Schema or OpenAPI Modes New modes that MDS can support (carshare, passenger services, delivery robots, etc) labels Apr 24, 2023
@schnuerle schnuerle added this to the 2.0.0 milestone Apr 24, 2023
@thekaveman
Copy link
Collaborator Author

thekaveman commented Apr 24, 2023

What are the values for micromobility?

The micromobility mode does not use the fare_attributes property of trip: https://github.com/openmobilityfoundation/mobility-data-specification/blob/release-2.0.0/modes/micromobility.md#fare-attributes

Stops may be a bit of an outlier right now and should just stay aligned with GBFS and reference that externally.

Roger 👍 In openmobilityfoundation/mds-openapi#5 I updated the casing to match exactly with GBFS.

For the modes, I think 1) paratransit needs to be removed from delivery robots, 2) credit_card added to delivery robots.

Done in openmobilityfoundation/mds-openapi#5

But account_number and phone could be added to all modes, and then maybe mobile needs to be called mobile_app for clarity?

Happy to do this as well.

@thekaveman
Copy link
Collaborator Author

@schnuerle in thinking about adding phone and changing mobile to mobile_app... It still doesn't seem clear to me, how does phone differ from mobile_app?

@schnuerle
Copy link
Member

Phone is when a reservation is made via a phone call, to a phone number. So it's different from a mobile app.

thekaveman added a commit to openmobilityfoundation/mds-openapi that referenced this issue Apr 27, 2023
@schnuerle
Copy link
Member

Payment types are aligned in this commit. Ready to close this issue when confirmed by @thekaveman.

@thekaveman
Copy link
Collaborator Author

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modes New modes that MDS can support (carshare, passenger services, delivery robots, etc) question Further information is requested Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

No branches or pull requests

2 participants