Add new battery_charged event type reason
#237
Conversation
When the battery of a device is too low, the service yields the `unavailable` event type with the `low_battery` reason. Then the device may charge itself (for example because it has been plugged to a charging dock by the last customer, or because the device has a solar panel). Once the battery is charged enough, the service can yield an `available` event type with the `battery_charged` reason. [closes openmobilityfoundation#210]
bors-ltd
force-pushed
the
bluesystems/battery_charged
branch
from
64c0986
to
d12b774
Compare
|
@karcass this PR needs to wait on determine how to support multiple modes, see #170. Can you prepare a PR to revert this in Dev? This also needs some tweaks on the JSON schema |
|
@dbaty, just to clarify why I asked for a reversion of this PR. I think we need to have a clear way we add an support additional modes to MDS, as there are a number of difference in the core technologies, data we need and legal frameworks to support for different modes. In #95, I propose a directory structure, with the What PR that we have to close #170 should have a how to guide about writing MDS support for different modes. |
|
It's not clear to me how this event is linked to different transport modes. Could they not apply to electric bikes and scooters that are currently supported? |
This pull request addresses #210.
When the battery of a device is too low, the service yields the
unavailableevent type with thelow_batteryreason. Then thedevice may charge itself (for example because it has been plugged to a
charging dock by the last customer, or because the device has a solar
panel). Once the battery is charged enough, the service can yield an
availableevent type with thebattery_chargedreason.[closes #210]