agency: Vehicle Update response code should be 200 #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tonial
changed the title
According to the RFC : https://tools.ietf.org/html/rfc7231#section-6.3.1 the HTTP response for an update (that does not create any object) can either be 200 (OK) or 202 (ACCEPTED) The later "indicates that the request has been accepted for processing, but the processing has not been completed." Since updating the vehicle_id should be quite fast, we should use a 200 response code.
tonial
force-pushed
the
alaurent/agency_vehicle_update_response_status_code
branch
from
7959659
to
e66cf5f
Compare
sarob
added
Agency
Retzoh
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain pull request
According to the RFC : https://tools.ietf.org/html/rfc7231#section-6.3.1
the HTTP response for an update (that does not create any object) can
either be 200 (OK) or 202 (ACCEPTED)
The later "indicates that the request has been
accepted for processing, but the processing has not been completed."
Since updating the vehicle_id should be quite fast, we should use a 200
response code.
Is this a breaking change
Impacted Spec
agencyAdditional context
Add any other context or screenshots about the feature request here.