Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GBFS references #508

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Change GBFS references #508

merged 2 commits into from
Jun 9, 2020

Conversation

hunterowens
Copy link
Collaborator

Since GBFS 2.0 is a thing and the language I wrote about GBFS and micromobility is out of date, this updates provider to require using GBFS 2.0 for overall implementation.

@hunterowens hunterowens requested a review from a team as a code owner June 2, 2020 00:14
@hunterowens hunterowens requested a review from a team June 2, 2020 00:14
@thekaveman thekaveman changed the base branch from master to dev June 2, 2020 02:22
@thekaveman thekaveman added documentation documentation change can be for code and/or markdown pages Provider Specific to the Provider API labels Jun 2, 2020
@thekaveman thekaveman added this to the 1.0.0 milestone Jun 2, 2020
marie-x
marie-x previously approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@marie-x marie-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

thekaveman
thekaveman previously approved these changes Jun 4, 2020
View reviewed changes
@jfh01
Copy link
Contributor

jfh01 commented Jun 4, 2020 •
edited
Loading

Added suggested language pointing people to /vehicles and to the MDS / GBFS guidance document.

@thekaveman thekaveman dismissed stale reviews from marie-x and themself via 053a662 June 4, 2020 21:50
@schnuerle schnuerle merged commit 0ed09ae into dev Jun 9, 2020
@schnuerle schnuerle deleted the change-gbfs branch July 31, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfh01 jfh01 jfh01 left review comments

@thekaveman thekaveman thekaveman approved these changes

@vabhinivesh vabhinivesh vabhinivesh approved these changes

@marie-x marie-x marie-x left review comments

Assignees
No one assigned
Labels
documentation documentation change can be for code and/or markdown pages Provider Specific to the Provider API
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hunterowens @jfh01 @marie-x @thekaveman @vabhinivesh @schnuerle