Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'located' event_type #570

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Add 'located' event_type #570

merged 4 commits into from
Aug 28, 2020

Conversation

schnuerle
Copy link
Member

Per issue #566, adding the 'located' event type to the docs, state machine, and schema.

@schnuerle schnuerle requested a review from a team as a code owner August 28, 2020 15:24
@schnuerle schnuerle linked an issue Aug 28, 2020 that may be closed by this pull request
Add 'located' event_type from 'Unknown' for symmetry with 'missing' #566
Closed
@schnuerle schnuerle added this to the 1.0.0 milestone Aug 28, 2020
@schnuerle schnuerle added Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram labels Aug 28, 2020
@schnuerle schnuerle marked this pull request as draft August 28, 2020 15:28
@thekaveman
added 'located' event_type to schema template
20fe17d 
regenerate schemas from template
thekaveman
thekaveman approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schnuerle schnuerle marked this pull request as ready for review August 28, 2020 16:13
@schnuerle schnuerle requested review from a team August 28, 2020 16:13
@schnuerle schnuerle merged commit 99e97ae into release-1.0.0 Aug 28, 2020
@schnuerle schnuerle deleted the ms-located-event-type branch August 28, 2020 16:14
@schnuerle schnuerle mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees
No one assigned
Labels
Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Add 'located' event_type from 'Unknown' for symmetry with 'missing'
2 participants
@schnuerle @thekaveman