Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating policy query parameter language to be clearer. #742

Conversation

janedotx
Copy link
Contributor

Explain pull request

This is a response to this issue: #668

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • policy

@janedotx janedotx requested a review from a team as a code owner January 20, 2022 01:07
@schnuerle schnuerle linked an issue Jan 20, 2022 that may be closed by this pull request
@schnuerle schnuerle added the Policy Specific to the Policy API label Jan 20, 2022
Copy link
Contributor

@jrheard jrheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks very much for doing this!

@schnuerle schnuerle added this to the 2.0.0 milestone Nov 29, 2022
@schnuerle
Copy link
Member

@jean-populus what do you think of this suggested wording change?

@jean-populus
Copy link
Collaborator

looks great @janedotx !

@schnuerle schnuerle merged commit e0c2887 into openmobilityfoundation:dev Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Policy Specific to the Policy API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy API: clarify meaning of start_date and end_date parameters
4 participants