Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a "trip" for the purposes of analyses #762

Merged
merged 1 commit into from Jan 9, 2023

Conversation

jiffyclub
Copy link
Contributor

Explain pull request

This addresses #748 by adding a definition of a "trip" to the general-information.md file. The definition is meant for the purposes of analysis in particular, and not for filtering which data points are exchanged as part of MDS endpoints.

I wasn't sure on the exact right spot for this since I hadn't seen anything like this done before in MDS, but I'm open to suggestions on that and the wording of the definition itself.

Is this a breaking change

  • No, not breaking

I don't consider this a breaking change since it doesn't effect the data interchange at all, only downstream analytics, but I might be missing something.

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • policy
  • provider

In a way, all of these and none of these. 馃

@jiffyclub jiffyclub requested a review from a team as a code owner April 28, 2022 01:28
@jiffyclub jiffyclub mentioned this pull request Apr 28, 2022
general-information.md Outdated Show resolved Hide resolved
@jiffyclub
Copy link
Contributor Author

Follow-up from the MDS working group meeting on 2022-04-28, I'll make the language about what providers should report more definitive and reference all MDS endpoints. I'll also link from other places that discuss trips to this definition.

@schnuerle schnuerle added Provider Specific to the Provider API Agency Specific to the Agency API Policy Specific to the Policy API labels Aug 4, 2022
@schnuerle schnuerle added this to the 2.0.0 milestone Aug 4, 2022
@schnuerle schnuerle linked an issue Aug 4, 2022 that may be closed by this pull request
Copy link
Collaborator

@jean-populus jean-populus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @jiffyclub !

This addresses openmobilityfoundation#748 by adding a definition of a "trip" to the
general-information.md file. The definition is meant for the
purposes of analysis in particular, and not for filtering which
data points are exchanged as part of MDS endpoints.

I wasn't sure on the exact right spot for this since I hadn't seen
anything like this done before in MDS, but I'm open to suggestions
on that and the wording of the definition itself.
@jiffyclub
Copy link
Contributor Author

Made the update clarifying that providers should still send all info in all cases and made a link from provider trips to this definition.

@schnuerle schnuerle merged commit ea1d185 into openmobilityfoundation:dev Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Policy Specific to the Policy API Provider Specific to the Provider API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trip definitions
3 participants