Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add BCycle to Providers list #783

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

johnadali
Copy link
Contributor


name: Default
about: Suggest changes to MDS
title: Request to add BCycle to Providers List


MDS Pull Request

Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.

To avoid complications and help make the Review process as smooth as possible, make sure to:

  1. Target dev branch. Please ensure you are targeting dev, not main.
  2. Keep the "Allow edits from maintainers" button checked to help us resolve some issues for you.
  3. Be ready to resolve any merge conflicts before we approve your Pull Request.
  4. Have an up to date profile, per our Github community profile guildance.

Explain pull request

Requesting to add BCycle to Providers list

Is this a breaking change

No

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

  • Yes, breaking
  • No, not breaking
  • I'm not sure

Impacted Spec

Which spec(s) will this pull request impact?

provider

  • agency
  • policy
  • provider

Additional context

Add any other context or screenshots about the feature request here.

@johnadali johnadali requested a review from a team as a code owner August 18, 2022 15:56
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2022

CLA assistant check
All committers have signed the CLA.

@schnuerle
Copy link
Member

Looks great @johnadali! Thanks and welcome. We can approve it right after you click here and digitally sign the CLA. https://cla-assistant.io/openmobilityfoundation/mobility-data-specification?pullRequest=783

@schnuerle schnuerle added the identifier change provider.csv or agencies.csv updates/additions label Aug 18, 2022
@schnuerle schnuerle added this to the 2.0.0 milestone Aug 18, 2022
@johnadali
Copy link
Contributor Author

Thanks @schnuerle, I have signed the CLA so we should be good to go! Please let me know if anything else is needed.

Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@schnuerle schnuerle merged commit a2b1f6b into openmobilityfoundation:dev Aug 29, 2022
@johnadali johnadali deleted the patch-1 branch August 29, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identifier change provider.csv or agencies.csv updates/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants