Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 757 publish date vs published date #784

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

schnuerle
Copy link
Member

Explain pull request

Recreation of previous PR #780 by @marie-x in hopes of resolving a CLA issue.

Per #757, proofreaders failed to catch the differently-named fields for the same concept in Policy and Geography.

Is this a breaking change

  • Yes, breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • provider

Additional context

I considered standardizing on publish_date but that was 57 changes in 25 files

@schnuerle schnuerle requested a review from a team as a code owner September 6, 2022 14:41
@schnuerle schnuerle added this to the 2.0.0 milestone Sep 6, 2022
@schnuerle schnuerle added the Provider Specific to the Provider API label Sep 6, 2022
@schnuerle schnuerle merged commit 0401c67 into dev Sep 6, 2022
@marie-x marie-x deleted the issue-757-publish_date-vs-published_date branch September 6, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Provider Specific to the Provider API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the property names publish_date and published_date in geography/policy API
2 participants