Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Poppy Mobility #795

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Adds Poppy Mobility #795

merged 3 commits into from
Dec 2, 2022

Conversation

teebot
Copy link
Contributor

@teebot teebot commented Oct 11, 2022

Registering Poppy as MDS provider


name: Default
about: Suggest changes to MDS
title:


MDS Pull Request

Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.

To avoid complications and help make the Review process as smooth as possible, make sure to:

  1. Target dev branch. Please ensure you are targeting dev, not main.
  2. Keep the "Allow edits from maintainers" button checked to help us resolve some issues for you.
  3. Be ready to resolve any merge conflicts before we approve your Pull Request.
  4. Have an up to date profile, per our Github community profile guildance.

Explain pull request

Please provide a clear and concise reason for this pull request and the impact of the change

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

  • Yes, breaking
  • No, not breaking
  • I'm not sure

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • policy
  • provider

Additional context

Add any other context or screenshots about the feature request here.

Registering Poppy as MDS provider
@teebot teebot requested a review from a team as a code owner October 11, 2022 12:55
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2022

CLA assistant check
All committers have signed the CLA.

@schnuerle schnuerle changed the base branch from main to dev October 12, 2022 14:35
@schnuerle schnuerle added the identifier change provider.csv or agencies.csv updates/additions label Oct 12, 2022
@schnuerle
Copy link
Member

Thank you please sign the CLA and we will get you officially added!

https://cla-assistant.io/openmobilityfoundation/mobility-data-specification?pullRequest=795

@schnuerle schnuerle added this to the 2.0.0 milestone Oct 12, 2022
@schnuerle
Copy link
Member

Hi we can't merge this change until you sign the license agreement for your contribution. Thanks!

@teebot
Copy link
Contributor Author

teebot commented Dec 2, 2022

hi,
sorry missed that. it's signed

@schnuerle schnuerle merged commit 813a14e into openmobilityfoundation:dev Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identifier change provider.csv or agencies.csv updates/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants