Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subcommands with specified allowed actors doesn't print in help.md #696

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

DiFFoZ
Copy link
Member

@DiFFoZ DiFFoZ commented Apr 14, 2023

Fixes #684

I also removed the part of code that trying to add permission grant access to the command instead of to a list of permissions, but it didn't work correctly, here is the diff of how it should have been:

## Commands
 - kit [create|remove] [player] <name>
   id: Kits.Commands.CommandKit
   permissions:
+  - Kits:commands.kit: Grants access to the Kits.Commands.CommandKit command.
   - Kits:commands.kit.give.other: Give the kit to another player but it will checks if another player has permission, money, etc..
   - Kits:commands.kit.give.other.force: Force give the kit to another player without checks if the player has permission, money, etc..
 - kit create <name> [cooldown] [cost] [money] [vehicleId]
   id: Kits.Commands.CommandKitCreate
+  permissions:
+  - Kits:commands.kit.create: Grants access to the Kits.Commands.CommandKitCreate command.

## Permissions
-- Kits:commands.kit: Grants access to the Kits.Commands.CommandKit command.
-- Kits:commands.kit.give.other: Give the kit to another player but it will checks if another player has permission, money, etc..
-- Kits:commands.kit.give.other.force: Force give the kit to another player without checks if the player has permission, money, etc..
-- Kits:commands.kit.create: Grants access to the Kits.Commands.CommandKitCreate command.
 - Kits:nocooldown: Allows use kit without waiting for cooldown

If this preferred instead of old behaviour, I can return it and fix it.

@Trojaner Trojaner merged commit c0bca70 into main Jun 14, 2023
@DiFFoZ DiFFoZ deleted the fix/wrong_subcommands_help_writer branch June 16, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong subcommands description in help.md file
2 participants