Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce brackets #817

Merged
merged 3 commits into from Apr 27, 2024
Merged

Enforce brackets #817

merged 3 commits into from Apr 27, 2024

Conversation

rube200
Copy link
Contributor

@rube200 rube200 commented Apr 24, 2024

After last update .editorconfig now marks some missing brackets as errors.
This update consist in fixing those errors and refactor some code on edit classes along the way.

unturned/OpenMod.Unturned.Module.Shared/System.Drawing/Color.cs Dismissed Show dismissed Hide dismissed
framework/OpenMod.Core/Plugins/PluginAssemblyStore.cs Dismissed Show dismissed Hide dismissed
public override int GetHashCode() => Value.GetHashCode();
public override int GetHashCode()
{
return Value.GetHashCode();

Check notice

Code scanning / CodeQL

Useless call to GetHashCode() Note

Calling GetHashCode() on type short is redundant.
unturned/OpenMod.Unturned.Module.Shared/System.Drawing/Color.cs Dismissed Show dismissed Hide dismissed
unturned/OpenMod.Unturned.Module.Shared/System.Drawing/Color.cs Dismissed Show dismissed Hide dismissed
unturned/OpenMod.Unturned.Module.Shared/System.Drawing/Color.cs Dismissed Show dismissed Hide dismissed
@Trojaner Trojaner merged commit db1bbb1 into main Apr 27, 2024
16 checks passed
@Trojaner Trojaner deleted the enforce_brackets branch April 27, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants