Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete constructor in sensitivity model #452

Open
sriramab opened this issue Apr 28, 2020 · 5 comments
Open

Incomplete constructor in sensitivity model #452

sriramab opened this issue Apr 28, 2020 · 5 comments
Assignees

Comments

@sriramab
Copy link
Contributor

In the documentation on sensitivity analysis on this page https://openmole.org/Sensitivity.html#Specificconstructor

there are two constructor examples, both set evaluation to model , however there is no definition / declaration of what is the model. I think it would be a Task, but the examples miss these Tasks.

@JusteRaimbault
Copy link
Contributor

It was done on purpose to have light examples at this stage - knowing that these are rather advanced methods (and there is the link to the market example); but thinking about it since input/outputs are defined in the example it may be better to add a short task to have a runnable example - what do the doc masters @helenea @chapinux think?

@sriramab
Copy link
Contributor Author

sriramab commented Apr 28, 2020

may be a commented line that says: model could be one of the Tasks: ScalaTask, RTask, EmptyTask
My suggestion would be to not call it a model, but something like myModel because model sounds too general and could be a bit confusing and may need a second read.
Thank you

@chapinux
Copy link
Contributor

using custom names like myModel , myFile , myParameter , always seemed more obvious to me

@JusteRaimbault
Copy link
Contributor

Agree with both - will try to fix this quickly

@sriramab
Copy link
Contributor Author

sriramab commented Mar 9, 2021

This has not been fixed 😢 . Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants