Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version requirement update #126

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Python version requirement update #126

merged 2 commits into from
Oct 19, 2022

Conversation

godotalgorithm
Copy link
Collaborator

@godotalgorithm godotalgorithm commented Oct 6, 2022

CMake's automated detection of Python began pointing to inadequate versions (either 2.x or without numpy installed) on my develop machine, so I've updated the detection to make 3.x and numpy mandatory. I've also improved the main README in response to some recent confusion related to building MOPAC from source.

Status

  • Ready for merge

@codecov-commenter
Copy link

Codecov Report

Merging #126 (af7f344) into main (b1a173e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   66.46%   66.46%           
=======================================
  Files         331      331           
  Lines       73723    73723           
=======================================
  Hits        49001    49001           
  Misses      24722    24722           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@godotalgorithm godotalgorithm merged commit f0404b1 into main Oct 19, 2022
@godotalgorithm godotalgorithm deleted the python-update branch October 19, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants