Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate THREADS keyword #55

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

godotalgorithm
Copy link
Collaborator

As noted in #37, the THREADS keyword was previously deactivated because it relied on MKL-specific functions, and development of MOPAC has moved to more general support of BLAS & LAPACK libraries. However, all known threaded BLAS/LAPACK libraries are based on OpenMP, so we can again support the THREADS keyword through generic OpenMP API calls. The MKL-specific functionality has been hidden behind the MKL preprocessor variable for a while, which we are keeping in until the dense linear algebra refactor happens. There is some redundancy between the new OMP_ENABLED-filtered code blocks and the deprecated MKL-filtered code blocks, but it is practically irrelevant.

Status

  • Ready for merge

@codecov-commenter
Copy link

Codecov Report

Merging #55 (6d07c0b) into main (f230b06) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files         330      330           
  Lines       71684    71690    +6     
=======================================
+ Hits        48906    48912    +6     
  Misses      22778    22778           
Impacted Files Coverage Δ
src/run_mopac.F90 78.21% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f230b06...6d07c0b. Read the comment docs.

@godotalgorithm godotalgorithm merged commit fb8e8b5 into main Jun 10, 2022
@godotalgorithm godotalgorithm deleted the reactivate-threads-keyword branch June 10, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants