Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mopac-bz only if BUILD_WINMOPAC is set #63

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

awvwgk
Copy link
Contributor

@awvwgk awvwgk commented Jun 21, 2022

Building on Windows without BUILD_WINMOPAC enabled results in a missing install target mopac-bz.

CMake Error at CMakeLists.txt:283 (install):
  install TARGETS given target "mopac-bz" which does not exist.


-- Configuring incomplete, errors occurred!

Status

  • Ready for merge

@awvwgk awvwgk changed the title Only install mopac-bz only if BUILD_WINMOPAC is set Install mopac-bz only if BUILD_WINMOPAC is set Jun 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #63 (d9782b3) into main (5edb088) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   68.24%   68.24%           
=======================================
  Files         330      330           
  Lines       71703    71703           
=======================================
  Hits        48932    48932           
  Misses      22771    22771           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edb088...d9782b3. Read the comment docs.

@godotalgorithm godotalgorithm merged commit 993a3c6 into openmopac:main Jun 21, 2022
@godotalgorithm
Copy link
Collaborator

Thank you, this change is necessary to compile on Windows without the Intel Fortran compiler and its QuickWin library.

@awvwgk awvwgk deleted the mopac-bz branch June 21, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants