Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align OpenMP linking w/ BLAS #74

Merged
merged 13 commits into from
Jun 24, 2022
Merged

Align OpenMP linking w/ BLAS #74

merged 13 commits into from
Jun 24, 2022

Conversation

godotalgorithm
Copy link
Collaborator

This PR is intended to fix #73 by aligning how OpenMP is linked with CMake's find_package functionality, with an override path for the Mac packaging, which is not able to use find_package successfully right now because of CMake limitations.

Status

  • Ready for merge

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #74 (5000be2) into main (f10d4d9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   68.23%   68.23%   -0.01%     
==========================================
  Files         330      330              
  Lines       71706    71696      -10     
==========================================
- Hits        48932    48925       -7     
+ Misses      22774    22771       -3     
Impacted Files Coverage Δ
src/run_mopac.F90 78.04% <ø> (-0.21%) ⬇️
src/input/wrtkey.F90 64.13% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10d4d9...5000be2. Read the comment docs.

@godotalgorithm godotalgorithm merged commit 787a16f into main Jun 24, 2022
@godotalgorithm
Copy link
Collaborator Author

The source of confusion in the build system was CMake's find_package/find_library system, in conjunction with a version of libiomp5.so on the Linux GHA Runner that is a symbolic link to a (possibly non-portable) system library rather than Intel's redistributable library and appeared earlier in the search sequence. This confusion does not seem to cause problems for local builds, but it is the source of the portability problems here, and my only easy recourse is to avoid using find_package when building the Linux installer.

@godotalgorithm godotalgorithm deleted the omp-double-link branch June 24, 2022 20:22
@godotalgorithm godotalgorithm mentioned this pull request Jun 25, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenMP library conflicts on Linux
2 participants