-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align OpenMP linking w/ BLAS #74
Conversation
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 68.23% 68.23% -0.01%
==========================================
Files 330 330
Lines 71706 71696 -10
==========================================
- Hits 48932 48925 -7
+ Misses 22774 22771 -3
Continue to review full report at Codecov.
|
The source of confusion in the build system was CMake's find_package/find_library system, in conjunction with a version of libiomp5.so on the Linux GHA Runner that is a symbolic link to a (possibly non-portable) system library rather than Intel's redistributable library and appeared earlier in the search sequence. This confusion does not seem to cause problems for local builds, but it is the source of the portability problems here, and my only easy recourse is to avoid using find_package when building the Linux installer. |
This PR is intended to fix #73 by aligning how OpenMP is linked with CMake's find_package functionality, with an override path for the Mac packaging, which is not able to use find_package successfully right now because of CMake limitations.
Status