Catch resize exception and release client lock.

[jrobble]

Issues:

• OcvYoloDetection component deadlocks with strange frame sizes when using Triton openmpf#1697

---

This change is 

[brosenberg42]

We should be throwing MPFDetectionException(MPF_BAD_FRAME_SIZE, "<explanation>"). We can check the dimensions and throw before calling cv::resize. An other option is to put a try block around just the cv::resize call, catch cv::Exception, and throw the mpf exception.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jrobble)

---

cpp/OcvYoloDetection/triton/TritonInferencer.cpp line 265 at r1 (raw file):

            }
        } 
        catch (const std::exception &ex) {

In addition to my comments above, change this to:

catch (...) {
    releaseClientId(clientId, nullptr);
    throw;
}

We catch ... because we never want to be deadlocked. Ideally, we would be calling releaseClientId in a destructor for a ClientLease object, but that is a bigger change.

std::current_exception() is for when you want access to an exception outside of its catch block. It is usually used to move an exception between threads.

[jrobble]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)

---

cpp/OcvYoloDetection/triton/TritonInferencer.cpp line 265 at r1 (raw file):

Previously, brosenberg42 wrote…

In addition to my comments above, change this to:

catch (...) {
    releaseClientId(clientId, nullptr);
    throw;
}

We catch ... because we never want to be deadlocked. Ideally, we would be calling releaseClientId in a destructor for a ClientLease object, but that is a bigger change.

std::current_exception() is for when you want access to an exception outside of its catch block. It is usually used to move an exception between threads.

I did it a different way, as discussed.

[brosenberg42]

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @jrobble)

[jrobble]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jrobble)