Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JpaDao.findAll() should return java.util.stream.Stream<T> instead of List<T> #1440

Open
brosenberg42 opened this issue Oct 26, 2021 · 0 comments
Assignees
Milestone

Comments

@brosenberg42
Copy link
Member

brosenberg42 commented Oct 26, 2021

This will incrementally pull results out of the database, instead of pulling everything out at once. Also, change callers of JpaDao.findAll() to operate in a way that doesn't put all of the results in a collection unnecessarily. For cases where it would be difficult to convert the caller to use stream operations, the stream can be converted to an iterator and still get the same benefits of using the stream directly.


Related, [GET] /jobs doesn't seem to be used since the jobs page uses /jobs-paged. To be clear [GET] /jobs is used by getJobsList() in services.js, but nothing uses getJobsList(). We should remove that function and endpoint.

@brosenberg42 brosenberg42 added this to the Milestone 2 milestone Oct 26, 2021
@brosenberg42 brosenberg42 added this to To do in OpenMPF: Development via automation Oct 26, 2021
@jrobble jrobble moved this from To do to Planned in OpenMPF: Development Oct 28, 2021
@clnowacki clnowacki moved this from Planned to In Progress in OpenMPF: Development Aug 4, 2022
@clnowacki clnowacki moved this from In Progress to Testing in OpenMPF: Development Aug 4, 2022
@clnowacki clnowacki moved this from Testing to Closed in OpenMPF: Development Aug 4, 2022
@jrobble jrobble modified the milestones: Milestone 2, Milestone 3 Aug 29, 2022
@clnowacki clnowacki modified the milestones: Milestone 3, Milestone 2 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

No branches or pull requests

3 participants