Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify AdminStatisticsController so that it doesn't hold all jobs in memory at once. #1441

Closed
brosenberg42 opened this issue Oct 26, 2021 · 0 comments

Comments

@brosenberg42
Copy link
Member

brosenberg42 commented Oct 26, 2021

This was causing OutOfMemoryErrors for users. This page is just calculating summary statistics, so it doesn't need to hold all of the jobs in memory at once. #1440 will need to completed first so there is a way to get the jobs lazily.

This will still be very slow when there are a lot of jobs, but at least it won't cause OutOfMemoryError. There might be a way to get the same information in SQL query, which would be significantly faster.

@brosenberg42 brosenberg42 added this to the Milestone 2 milestone Oct 26, 2021
@brosenberg42 brosenberg42 added this to To do in OpenMPF: Development via automation Oct 26, 2021
@jrobble jrobble added the bug label Oct 26, 2021
@jrobble jrobble moved this from To do to Planned in OpenMPF: Development Oct 28, 2021
@jrobble jrobble closed this as completed Feb 17, 2022
OpenMPF: Development automation moved this from Planned to Closed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants