Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protobuf size limit configurable. #1426

Merged
merged 3 commits into from Oct 7, 2021

Conversation

brosenberg42
Copy link
Member

@brosenberg42 brosenberg42 commented Oct 6, 2021

@brosenberg42 brosenberg42 self-assigned this Oct 6, 2021
Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)


trunk/workflow-manager/src/main/java/org/mitre/mpf/wfm/camel/routes/DetectionResponseRouteBuilder.java, line 96 at r1 (raw file):

			.routeId(routeId)
			.setExchangePattern(ExchangePattern.InOnly)
			.unmarshal(protobufDataFormatFactory.create(DetectionProtobuf.DetectionResponse::newBuilder)) // Unpack the protobuf response.

Do we want to update the following line in DlqRouteBuilder.java?

.unmarshal().protobuf(DetectionProtobuf.DetectionRequest.getDefaultInstance()).convertBodyTo(String.class)

In theory, any message could end up in the DLQ.

Copy link
Member Author

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)


trunk/workflow-manager/src/main/java/org/mitre/mpf/wfm/camel/routes/DetectionResponseRouteBuilder.java, line 96 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

Do we want to update the following line in DlqRouteBuilder.java?

.unmarshal().protobuf(DetectionProtobuf.DetectionRequest.getDefaultInstance()).convertBodyTo(String.class)

In theory, any message could end up in the DLQ.

Done.

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

@brosenberg42 brosenberg42 merged commit b633ee7 into master Oct 7, 2021
@brosenberg42 brosenberg42 deleted the hotfix/protobuf-size-limit branch October 7, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants