-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hf/ffmpeg version issue #1726
Hf/ffmpeg version issue #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
trunk/mpf-system-tests/src/main/java/org/mitre/mpf/mst/OutputChecker.java
line 338 at r1 (raw file):
try { Integer.parseInt(expected); // Double.parseDouble will successfully parse integer values, but we do not
I think the implication here is that previously attempted String comparison is sufficient for matching Integers. I think we should specifically say that in this comment or in matchesSafely()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @jrobble)
trunk/mpf-system-tests/src/main/java/org/mitre/mpf/mst/OutputChecker.java
line 338 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
I think the implication here is that previously attempted String comparison is sufficient for matching Integers. I think we should specifically say that in this comment or in
matchesSafely()
.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
Issues:
This change is