AC-580: Fix ProGuard and SDK level #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak140596
pushed a commit
to deepak140596/openmrs-contrib-android-client
that referenced
this pull request
Apr 21, 2019
talha3111997
pushed a commit
to talha3111997/openmrs-contrib-android-client
that referenced
this pull request
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
There are multiple warnings that should be ignored with
-dontwarnon all the dependencies that error-ed when minimizing. (see this thread on why ProGuard is now failing) And the target SDK level should match the compile SDK version.Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-580
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)