New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add interstitial system admin page that links to non-core apps #21
Conversation
@ibacher please review my PR. |
packages/esm-admin-systemconfig-app/src/dashboard/index.component.tsx
Outdated
Show resolved
Hide resolved
@ibacher I am not sure why tests are failing, but they probably need a rerun but I am not able to trigger that. |
Hi @hadijahkyampeire, it seems the lock file is not up to date. Could you please run |
Thanks @jayasanka-sack I have done that, hopefully the tests will pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hadijahkyampeire! Looking very good!
One thing: do we need the config-schema copy.ts
file?
@@ -8,7 +8,7 @@ const OpenConceptLabCardLink: React.FC = () => { | |||
const header = t('manageConcepts', 'Manage Concepts'); | |||
return ( | |||
<Layer> | |||
<ClickableTile id={`clickable-tile-${header}`} href={`${window.spaBase}/ocl`} target="_blank" rel="no-refferer"> | |||
<ClickableTile id={`clickable-tile-${header}`} href={`${window.spaBase}/ocl`} target="_blank" rel="norefferer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<ClickableTile id={`clickable-tile-${header}`} href={`${window.spaBase}/ocl`} target="_blank" rel="norefferer"> | |
<ClickableTile id={`clickable-tile-ocl`} href={`${window.spaBase}/ocl`} target="_blank" rel="norefferer"> |
packages/esm-system-admin-app/src/dashboard/index.component.tsx
Outdated
Show resolved
Hide resolved
- Expose legacy admin link card as an extension - Remove the `id` prop from `ClickableTile` components - Delete the unused `config-schema-copy.ts` file
packages/esm-admin-openconceptlab-app/src/admin-ocl-card-link.component.tsx
Show resolved
Hide resolved
Thanks @denniskigen and @ibacher |
@hadijahkyampeire Please remember to select Squash and Merge when you merge a PR. |
oh, yah, sorry, I thought it was the default. |
Is the next step adding this package to the |
Yes, otherwise it won't show up by default. Try to add it near the openconceptlab line (I'm trying to keep modules from monorepos near each other). |
Requirements
Summary
App switcher
namedSystem Administration
which links to the above-mentioned page.ExtensionSlot
for card links that all apps that want to add card links can use. I have currently added theOCL
cardLink since they are in the same repo.Usage e.g in the Form builder
And add an extension in
index.ts
likeScreenshots
Issue
None.