Merge branch 'master' of https://github.com/openmrs/openmrs-esm-core

.eslintrc

@@ -1,4 +1,5 @@
 {
   "extends": ["ts-react-important-stuff", "plugin:prettier/recommended"],
-  "parser": "@babel/eslint-parser"
+  "parser": "@babel/eslint-parser",
+  "ignorePatterns": ["**/*.test.tsx"]
 }

packages/apps/esm-primary-navigation-app/src/components/navbar/navbar.component.tsx

@@ -2,9 +2,9 @@ import React, { useCallback, useMemo, useState } from "react";
 import {
   LoggedInUser,
   useLayoutType,
-  navigate,
   ExtensionSlot,
   useAssignedExtensionIds,
+  ConfigurableLink,
 } from "@openmrs/esm-framework";
 import {
   HeaderContainer,
@@ -27,8 +27,6 @@ import Logo from "../logo/logo.component";
 import styles from "./navbar.component.scss";
 import OfflineBanner from "../offline-banner/offline-banner.component";
 
-const HeaderLink: any = HeaderName;
-
 export interface NavbarProps {
   user: LoggedInUser;
   allowedLocales: Array<string>;
@@ -85,15 +83,12 @@ const Navbar: React.FC<NavbarProps> = ({
               isActive={isActivePanel("sideMenu")}
             />
           )}
-          <HeaderLink
-            prefix=""
-            onClick={() => {
-              navigate({ to: "${openmrsSpaBase}/home" });
-              hidePanel();
-            }}
+          <ConfigurableLink
+            className="bx--header__name"
+            to="${openmrsSpaBase}/home"
           >
             <Logo />
-          </HeaderLink>
+          </ConfigurableLink>
           <ExtensionSlot
             className={styles.dividerOverride}
             extensionSlotName="top-nav-info-slot"

packages/apps/esm-primary-navigation-app/src/root.component.test.tsx

@@ -28,6 +28,10 @@ jest.mock("@openmrs/esm-framework", () => ({
   }),
   refetchCurrentUser: jest.fn(),
   subscribeConnectivity: jest.fn(),
+  navigate: jest.fn(),
+  ConfigurableLink: jest.fn(() => {
+    return <a href="#">Mock EMR</a>;
+  }),
 }));
 
 jest.mock("./root.resource", () => ({

packages/framework/esm-styleguide/src/components/_breadcrumbs.scss

@@ -1,7 +1,7 @@
-.breadcrumbs-container {
+nav.breadcrumbs-container {
   padding: 1rem;
 
-  nav ol li {
+  ol li {
     display: inline-flex;
   }
 }

pull_request_template.md

@@ -0,0 +1,42 @@
+## Requirements
+
+- [ ] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide).
+- [ ] I checked for feature overlap with [**existing widgets**](https://om.rs/directory).
+
+
+## Summary
+
+<!--
+Required.
+Please describe what problems your PR addresses.
+-->
+
+
+## Screenshots
+
+*None.*
+<!--
+Optional.
+If possible, please insert any screenshots/videos of your changes here.
+Don't forget to remove the *None.* above if you do fill this section.
+-->
+
+
+## Related Issue
+
+*None.*
+<!--
+Optional.
+If present, please link any related issue here, e.g. "https://issues.openmrs.org/browse/123").
+Don't forget to remove the *None.* above if you do fill this section.
+-->
+
+
+## Other
+
+*None.*
+<!--
+Optional.
+Anything else that isn't covered by one of the sections above.
+Don't forget to remove the *None.* above if you do fill this section.
+-->