(feat) Better script loading error #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -388 kB (-10.1%) 👏 Total Size: 3.46 MB
ℹ️ View Unchanged
|
denniskigen
requested review from
ibacher and
brandones
and removed request for
ibacher
ibacher
approved these changes
May 30, 2024
|
Nice one! |
ibacher
reviewed
May 30, 2024
| @@ -2,6 +2,7 @@ | |||
| 'use strict'; | |||
| // hack to make the types defined in esm-globals available here | |||
| import { dispatchToastShown, type ImportMap } from '@openmrs/esm-globals'; | |||
| import { getCoreTranslation } from '@openmrs/esm-translations'; | |||
There was a problem hiding this comment.
Could you mark @openmrs/esm-translations as a peer dep of this sub-component. I think that will fix the size growth.
denniskigen
force-pushed
the
feat/better-script-loading-error-message
branch
from
840c9cc
to
e76a7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR tweaks the content of the script loading error message and makes it translatable by adding the corresponding keys and strings to the Core translations library.
Screenshots
Before
After
Related Issue
Other