Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Add support for setting custom workspace title #1067

Merged
merged 4 commits into from
Jul 3, 2024
Merged

(feat) Add support for setting custom workspace title #1067

merged 4 commits into from
Jul 3, 2024

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This allows workspaces to set their own title dynamically, including setting custom React components as the title.

Screenshots

recording-2024-07-02_13.13.48.mp4

Related Issue

Needed for https://openmrs.atlassian.net/browse/O3-3246

Other

brandones
brandones commented Jul 2, 2024
View reviewed changes
packages/framework/esm-styleguide/src/workspaces/types.ts
@@ -37,7 +38,21 @@ export interface DefaultWorkspaceProps {
* will directly close the workspace without any prompt
*/
closeWorkspaceWithSavedChanges(closeWorkspaceOptions?: CloseWorkspaceOptions): void;
handlePostResponse?(): void;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what this is or why it was here, but it appears not to be used anywhere (based on some github searching)

Copy link
Member

@donaldkibet donaldkibet Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in esm-fast-data-entry to handle postSubmission action. https://github.com/openmrs/openmrs-esm-fast-data-entry-app/blob/79bdd85e23c1245d5daee1d0d1137b00cdb871fc/src/FormBootstrap.tsx#L161 but i guess we can remove it since we aren't using it with workspaces.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Size Change: -364 kB (-9.07%) ✅

Total Size: 3.65 MB

Filename Size Change
packages/shell/esm-app-shell/dist/openmrs.e29aa9ef2f98ac7a.js 0 B -364 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/331.js 27.3 kB 0 B
packages/apps/esm-devtools-app/dist/667.js 6.97 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/762.js 2.69 kB 0 B
packages/apps/esm-devtools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-devtools-app/dist/875.js 9.93 kB 0 B
packages/apps/esm-devtools-app/dist/884.js 15.2 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 166 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 331 B 0 B
packages/apps/esm-devtools-app/dist/main.js 3.15 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.19 kB 0 B
packages/apps/esm-help-menu-app/dist/21.js 5.71 kB 0 B
packages/apps/esm-help-menu-app/dist/248.js 7.06 kB 0 B
packages/apps/esm-help-menu-app/dist/474.js 705 B 0 B
packages/apps/esm-help-menu-app/dist/667.js 6.97 kB 0 B
packages/apps/esm-help-menu-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-help-menu-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-help-menu-app/dist/884.js 15.2 kB 0 B
packages/apps/esm-help-menu-app/dist/889.js 166 kB 0 B
packages/apps/esm-help-menu-app/dist/958.js 1.88 kB 0 B
packages/apps/esm-help-menu-app/dist/main.js 9.89 kB 0 B
packages/apps/esm-help-menu-app/dist/openmrs-esm-help-menu-app.js 3.13 kB 0 B
packages/apps/esm-implementer-tools-app/dist/271.js 723 B 0 B
packages/apps/esm-implementer-tools-app/dist/319.js 639 B 0 B
packages/apps/esm-implementer-tools-app/dist/426.js 24.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/460.js 748 B 0 B
packages/apps/esm-implementer-tools-app/dist/482.js 15.2 kB 0 B
packages/apps/esm-implementer-tools-app/dist/523.js 5.74 kB 0 B
packages/apps/esm-implementer-tools-app/dist/528.js 134 kB 0 B
packages/apps/esm-implementer-tools-app/dist/56.js 3.08 kB 0 B
packages/apps/esm-implementer-tools-app/dist/560.js 14.1 kB 0 B
packages/apps/esm-implementer-tools-app/dist/574.js 563 B 0 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.93 kB 0 B
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB 0 B
packages/apps/esm-implementer-tools-app/dist/625.js 564 B 0 B
packages/apps/esm-implementer-tools-app/dist/644.js 723 B 0 B
packages/apps/esm-implementer-tools-app/dist/657.js 7.03 kB 0 B
packages/apps/esm-implementer-tools-app/dist/71.js 6.98 kB 0 B
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/757.js 563 B 0 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/791.js 283 B 0 B
packages/apps/esm-implementer-tools-app/dist/803.js 61.4 kB 0 B
packages/apps/esm-implementer-tools-app/dist/807.js 562 B 0 B
packages/apps/esm-implementer-tools-app/dist/833.js 691 B 0 B
packages/apps/esm-implementer-tools-app/dist/889.js 166 kB 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 78.4 kB 0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.33 kB 0 B
packages/apps/esm-login-app/dist/111.js 1.22 kB 0 B
packages/apps/esm-login-app/dist/126.js 2.5 kB 0 B
packages/apps/esm-login-app/dist/173.js 1.22 kB 0 B
packages/apps/esm-login-app/dist/224.js 258 B 0 B
packages/apps/esm-login-app/dist/236.js 272 B 0 B
packages/apps/esm-login-app/dist/240.js 366 B 0 B
packages/apps/esm-login-app/dist/271.js 810 B 0 B
packages/apps/esm-login-app/dist/272.js 266 B 0 B
packages/apps/esm-login-app/dist/290.js 22.3 kB 0 B
packages/apps/esm-login-app/dist/319.js 748 B 0 B
packages/apps/esm-login-app/dist/336.js 233 B 0 B
packages/apps/esm-login-app/dist/363.js 31.6 kB 0 B
packages/apps/esm-login-app/dist/460.js 825 B 0 B
packages/apps/esm-login-app/dist/539.js 300 B 0 B
packages/apps/esm-login-app/dist/56.js 3.07 kB 0 B
packages/apps/esm-login-app/dist/574.js 637 B 0 B
packages/apps/esm-login-app/dist/625.js 638 B 0 B
packages/apps/esm-login-app/dist/627.js 258 B 0 B
packages/apps/esm-login-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/644.js 810 B 0 B
packages/apps/esm-login-app/dist/667.js 6.97 kB 0 B
packages/apps/esm-login-app/dist/673.js 286 B 0 B
packages/apps/esm-login-app/dist/735.js 2.62 kB 0 B
packages/apps/esm-login-app/dist/757.js 777 B 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/807.js 986 B 0 B
packages/apps/esm-login-app/dist/833.js 761 B 0 B
packages/apps/esm-login-app/dist/884.js 15.2 kB 0 B
packages/apps/esm-login-app/dist/889.js 166 kB 0 B
packages/apps/esm-login-app/dist/main.js 57.8 kB 0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.38 kB 0 B
packages/apps/esm-offline-tools-app/dist/271.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/319.js 1.13 kB 0 B
packages/apps/esm-offline-tools-app/dist/460.js 1.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/538.js 91.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/56.js 3.08 kB 0 B
packages/apps/esm-offline-tools-app/dist/574.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/625.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/644.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/667.js 6.97 kB 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/757.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/833.js 1.21 kB 0 B
packages/apps/esm-offline-tools-app/dist/884.js 15.2 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 166 kB 0 B
packages/apps/esm-offline-tools-app/dist/975.js 57 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 148 kB 0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.31 kB 0 B
packages/apps/esm-primary-navigation-app/dist/271.js 270 B 0 B
packages/apps/esm-primary-navigation-app/dist/319.js 232 B 0 B
packages/apps/esm-primary-navigation-app/dist/460.js 266 B 0 B
packages/apps/esm-primary-navigation-app/dist/567.js 23 kB 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 231 B 0 B
packages/apps/esm-primary-navigation-app/dist/577.js 7.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/625.js 231 B 0 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-primary-navigation-app/dist/644.js 270 B 0 B
packages/apps/esm-primary-navigation-app/dist/667.js 6.98 kB 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/757.js 237 B 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/807.js 291 B 0 B
packages/apps/esm-primary-navigation-app/dist/833.js 258 B 0 B
packages/apps/esm-primary-navigation-app/dist/884.js 15.2 kB 0 B
packages/apps/esm-primary-navigation-app/dist/889.js 166 kB 0 B
packages/apps/esm-primary-navigation-app/dist/958.js 22.8 kB 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 47.3 kB 0 B
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.24 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 16.2 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 8.05 kB 0 B
packages/framework/esm-context/dist/openmrs-esm-context.js 1.09 kB 0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.89 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 891 B 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.16 kB 0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.66 kB 0 B
packages/framework/esm-framework/dist/126.openmrs-esm-framework.js 2.48 kB 0 B
packages/framework/esm-framework/dist/278.openmrs-esm-framework.js 14.5 kB 0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.93 kB 0 B
packages/framework/esm-framework/dist/619.openmrs-esm-framework.js 6.49 kB 0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.3 kB 0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.65 kB 0 B
packages/framework/esm-framework/dist/746.openmrs-esm-framework.js 6.14 kB 0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB 0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js 375 kB +77 B (+0.02%)
packages/framework/esm-globals/dist/openmrs-esm-globals.js 791 B 0 B
packages/framework/esm-navigation/dist/openmrs-esm-navigation.js 9.34 kB 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 15.8 kB 0 B
packages/framework/esm-routes/dist/openmrs-esm-utils.js 1.49 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 910 B 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 53.8 kB 0 B
packages/framework/esm-translations/dist/openmrs-esm-core-translations.js 1.77 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 18.3 kB 0 B
packages/shell/esm-app-shell/dist/06c1b95a262085a6.js 15.5 kB 0 B
packages/shell/esm-app-shell/dist/0f85df5904268497.js 915 B 0 B
packages/shell/esm-app-shell/dist/132c5e2b0b1864df.js 936 B 0 B
packages/shell/esm-app-shell/dist/1836f7c03d9970f0.js 1.19 kB 0 B
packages/shell/esm-app-shell/dist/2e155ac371cb8028.js 914 B 0 B
packages/shell/esm-app-shell/dist/2e1e924f130d5c4a.js 913 B 0 B
packages/shell/esm-app-shell/dist/5cabd4dde7fa1017.js 914 B 0 B
packages/shell/esm-app-shell/dist/68de905d6d73abf9.js 1.19 kB 0 B
packages/shell/esm-app-shell/dist/6c47b0ee6bc3b834.js 1.59 kB 0 B
packages/shell/esm-app-shell/dist/9ecd93b017b434c7.js 7.38 kB 0 B
packages/shell/esm-app-shell/dist/aff9b27d855b4be9.js 960 B 0 B
packages/shell/esm-app-shell/dist/d41c5c08280221b2.js 1.18 kB 0 B
packages/shell/esm-app-shell/dist/openmrs.87c12847f5cfa2cd.js 364 kB 0 B
packages/shell/esm-app-shell/dist/service-worker.js 45.9 kB +6 B (+0.01%)
packages/tooling/openmrs/dist/cli.js 2.9 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 3.19 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 1.32 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 543 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 2.71 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 437 B 0 B
packages/tooling/openmrs/dist/commands/start.js 850 B 0 B
packages/tooling/openmrs/dist/index.js 517 B 0 B
packages/tooling/openmrs/dist/runner.js 640 B 0 B
packages/tooling/openmrs/dist/utils/config.js 726 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 575 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 643 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 397 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 3.07 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 443 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 368 B 0 B
packages/tooling/openmrs/dist/utils/npmConfig.js 831 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 725 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 278 B 0 B
packages/tooling/webpack-config/dist/index.js 3.58 kB 0 B

compressed-size-action

denniskigen
denniskigen approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brandones. LGTM.

@brandones brandones merged commit dad1df6 into main Jul 3, 2024
11 checks passed
@brandones brandones deleted the workspace-title branch July 3, 2024 17:43
@denniskigen denniskigen mentioned this pull request Jul 5, 2024
Merged
3 tasks
Twiineenock pushed a commit to Twiineenock/openmrs-esm-core that referenced this pull request Jul 18, 2024
@brandones @Twiineenock
(feat) Add support for setting custom workspace title (openmrs#1067)
8a2fa8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldkibet donaldkibet donaldkibet left review comments

@denniskigen denniskigen denniskigen approved these changes

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@brandones @denniskigen @donaldkibet