(feat) Add support for setting default language via html lang attribute #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +127 B (0%) Total Size: 2.13 MB ℹ️ View Unchanged
|
vasharma05
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Can we change default-language with default-locale to match with the global setting default-locale?
Thanks for working on this @ibacher ! Really grateful 🙏
4 tasks
|
@vasharma05 Good call! |
ibacher
commented
Jun 12, 2023
| @@ -87,6 +89,7 @@ export async function runBuild(args: BuildArgs) { | |||
| env: "production", | |||
| apiUrl: buildConfig.apiUrl || args.apiUrl, | |||
| configUrls: configUrls, | |||
| defaultLocale: args.defaultLocale || buildConfig.defaultLocale, | |||
There was a problem hiding this comment.
Note: we should update the other properties to follow this pattern, i.e., explicitly CLI args should always override the configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Adds support for configuring a default language via the build config or command line arguments.
While this is technically duplicative of the
default_localesystem setting from the backend, we have good reason to ensure that some kind of default language is set in the frontend in case the backend is, for whatever reason unavailable.@vasharma05 To support Mekom's use-case, once merged, I'll add an overridable environment variable to the O3 RefApp so that this can be set on a per-instance basis.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-2155
Other