Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix loading config from relative URLs #703

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Jun 19, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

#674, in trying to allow absolute and relative URLs, adds a regression, specifically, by always injecting the openmrsSpaBase variable while resolving the URL. This adjust things to continue to use interpolateUrl here (so you can use ${openmrsSpaBase} in the config string, but by not automatically pre-pending it.

Because #674 introduced a breaking change, this PR is likely breaking for anyone relying on that change.

In the future, we need to carefully ensure that (feat) PRs do not change core semantics or if they do, we appropriately mark them as BREAKING.

Screenshots

Related Issue

Other

@ibacher ibacher force-pushed the fix/fix-config-relative-urls branch from 9839c3d to ad3ee09 Compare June 19, 2023 12:34
@ibacher ibacher merged commit d862238 into main Jun 26, 2023
5 of 6 checks passed
@ibacher ibacher deleted the fix/fix-config-relative-urls branch June 26, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant