(fix) Fix loading config from relative URLs #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
#674, in trying to allow absolute and relative URLs, adds a regression, specifically, by always injecting the
openmrsSpaBase
variable while resolving the URL. This adjust things to continue to useinterpolateUrl
here (so you can use${openmrsSpaBase}
in the config string, but by not automatically pre-pending it.Because #674 introduced a breaking change, this PR is likely breaking for anyone relying on that change.
In the future, we need to carefully ensure that (feat) PRs do not change core semantics or if they do, we appropriately mark them as BREAKING.
Screenshots
Related Issue
Other