-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Tweak pre-release
job skip logic
#735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tweaks the custom logic in the `pre-release` job of the CI workflow to accurately represent the signature of a release commit. This is so that GitHub Actions knows not to run the `pre-release` job for commits that cut releases.
Size Change: 0 B Total Size: 2.27 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Jul 19, 2023
Thanks @denniskigen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This PR tweaks the custom logic in the
pre-release
job of the CI workflow to accurately represent the signature of a release commit. This is so that GitHub Actions knows not to run thepre-release
job for commits that cut releases. The current logic assumes that release PRs are prefixed with(release)
, which is not correct. Typically, release commits in O3 use(chore) Release v
followed by a version number as their commit message.Screenshots
None
Related Issue
None
Other
None