Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Bump @carbon/react and @carbon/charts #770

Merged
merged 1 commit into from
Sep 24, 2023
Merged

(chore) Bump @carbon/react and @carbon/charts #770

merged 1 commit into from
Sep 24, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Sep 14, 2023 •
edited

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

In this PR, I bumped the @carbon/charts and @carbon/react packages to their latest versions. In #755, some of the changes included are obviated by upstream changes to @carbon/react. This upgrade allows us to leverage some potential bundle size reductions and improved functionality per the associated release notes for each package. The Carbon team are working on adding type support to individual components incrementally. This has led to some known issues with typings, which is why I've elected to add ambient type declarations from @carbon/react to each individual package's declarations file and omit some type declarations (for now).

Related Issue

#755

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited

Size Change: -110 kB (-4%)

Total Size: 2.81 MB

Filename Size Change
packages/apps/esm-implementer-tools-app/dist/139.js 0 B -11.7 kB (removed) 🏆
packages/apps/esm-implementer-tools-app/dist/31.js 0 B -60.1 kB (removed) 🏆
packages/apps/esm-login-app/dist/737.js 0 B -24.9 kB (removed) 🏆
packages/apps/esm-offline-tools-app/dist/82.js 0 B -51.8 kB (removed) 🏆
packages/apps/esm-primary-navigation-app/dist/113.js 0 B -11.6 kB (removed) 🏆
packages/shell/esm-app-shell/dist/openmrs.3151c5c45ff3fc15.js 0 B -320 kB (removed) 🏆
packages/apps/esm-offline-tools-app/dist/273.js 48.9 kB +48.9 kB (new file) 🆕
packages/shell/esm-app-shell/dist/openmrs.e65724545331f668.js 323 kB +323 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/68.js 4.29 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 175 kB +476 B (0%)
packages/apps/esm-devtools-app/dist/988.js 282 B 0 B
packages/apps/esm-devtools-app/dist/main.js 2.95 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.03 kB 0 B
packages/apps/esm-implementer-tools-app/dist/199.js 32.8 kB +4.41 kB (+16%) ⚠️
packages/apps/esm-implementer-tools-app/dist/220.js 4.43 kB -115 B (-3%)
packages/apps/esm-implementer-tools-app/dist/242.js 0 B -6.71 kB (removed) 🏆
packages/apps/esm-implementer-tools-app/dist/246.js 449 B +1 B (0%)
packages/apps/esm-implementer-tools-app/dist/263.js 6.66 kB 0 B
packages/apps/esm-implementer-tools-app/dist/319.js 595 B 0 B
packages/apps/esm-implementer-tools-app/dist/414.js 0 B -756 B (removed) 🏆
packages/apps/esm-implementer-tools-app/dist/426.js 1.66 kB 0 B
packages/apps/esm-implementer-tools-app/dist/466.js 5.85 kB +26 B (0%)
packages/apps/esm-implementer-tools-app/dist/499.js 2.87 kB +2 B (0%)
packages/apps/esm-implementer-tools-app/dist/500.js 2.83 kB 0 B
packages/apps/esm-implementer-tools-app/dist/519.js 400 B 0 B
packages/apps/esm-implementer-tools-app/dist/574.js 560 B 0 B
packages/apps/esm-implementer-tools-app/dist/575.js 713 B 0 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.81 kB +1 B (0%)
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB 0 B
packages/apps/esm-implementer-tools-app/dist/625.js 562 B 0 B
packages/apps/esm-implementer-tools-app/dist/657.js 562 B 0 B
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/757.js 560 B 0 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/807.js 1.44 kB +1 B (0%)
packages/apps/esm-implementer-tools-app/dist/833.js 681 B 0 B
packages/apps/esm-implementer-tools-app/dist/837.js 55.1 kB 0 B
packages/apps/esm-implementer-tools-app/dist/889.js 175 kB +478 B (0%)
packages/apps/esm-implementer-tools-app/dist/941.js 11.7 kB 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 4.12 kB +2 B (0%)
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.25 kB 0 B
packages/apps/esm-login-app/dist/144.js 21.7 kB 0 B
packages/apps/esm-login-app/dist/236.js 272 B 0 B
packages/apps/esm-login-app/dist/240.js 364 B 0 B
packages/apps/esm-login-app/dist/261.js 6.28 kB +31 B (0%)
packages/apps/esm-login-app/dist/263.js 6.65 kB 0 B
packages/apps/esm-login-app/dist/272.js 264 B 0 B
packages/apps/esm-login-app/dist/319.js 480 B 0 B
packages/apps/esm-login-app/dist/336.js 234 B 0 B
packages/apps/esm-login-app/dist/337.js 1.3 kB -4 B (0%)
packages/apps/esm-login-app/dist/390.js 0 B -603 B (removed) 🏆
packages/apps/esm-login-app/dist/438.js 6 kB 0 B
packages/apps/esm-login-app/dist/539.js 298 B 0 B
packages/apps/esm-login-app/dist/574.js 428 B 0 B
packages/apps/esm-login-app/dist/610.js 5.84 kB +34 B (+1%)
packages/apps/esm-login-app/dist/611.js 0 B -726 B (removed) 🏆
packages/apps/esm-login-app/dist/625.js 421 B 0 B
packages/apps/esm-login-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/642.js 10.7 kB +28 B (0%)
packages/apps/esm-login-app/dist/644.js 305 B 0 B
packages/apps/esm-login-app/dist/673.js 284 B 0 B
packages/apps/esm-login-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-login-app/dist/757.js 509 B 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/807.js 685 B 0 B
packages/apps/esm-login-app/dist/829.js 10.2 kB +53 B (+1%)
packages/apps/esm-login-app/dist/833.js 528 B 0 B
packages/apps/esm-login-app/dist/889.js 175 kB +478 B (0%)
packages/apps/esm-login-app/dist/967.js 576 B 0 B
packages/apps/esm-login-app/dist/main.js 3.48 kB -4 B (0%)
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.17 kB 0 B
packages/apps/esm-offline-tools-app/dist/202.js 9.73 kB +52 B (+1%)
packages/apps/esm-offline-tools-app/dist/206.js 7.41 kB +41 B (+1%)
packages/apps/esm-offline-tools-app/dist/263.js 6.66 kB 0 B
packages/apps/esm-offline-tools-app/dist/281.js 16.3 kB +3.94 kB (+32%) 🚨
packages/apps/esm-offline-tools-app/dist/290.js 0 B -438 B (removed) 🏆
packages/apps/esm-offline-tools-app/dist/316.js 2.06 kB 0 B
packages/apps/esm-offline-tools-app/dist/319.js 1.04 kB 0 B
packages/apps/esm-offline-tools-app/dist/391.js 305 B 0 B
packages/apps/esm-offline-tools-app/dist/412.js 1.58 kB 0 B
packages/apps/esm-offline-tools-app/dist/47.js 6.34 kB +32 B (+1%)
packages/apps/esm-offline-tools-app/dist/501.js 24.2 kB +769 B (+3%)
packages/apps/esm-offline-tools-app/dist/526.js 15.7 kB +111 B (+1%)
packages/apps/esm-offline-tools-app/dist/538.js 6.79 kB +36 B (+1%)
packages/apps/esm-offline-tools-app/dist/541.js 383 B -1 B (0%)
packages/apps/esm-offline-tools-app/dist/574.js 1.04 kB 0 B
packages/apps/esm-offline-tools-app/dist/594.js 11.4 kB +252 B (+2%)
packages/apps/esm-offline-tools-app/dist/625.js 1.04 kB 0 B
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/697.js 5.47 kB 0 B
packages/apps/esm-offline-tools-app/dist/733.js 290 B 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/752.js 2.83 kB 0 B
packages/apps/esm-offline-tools-app/dist/757.js 1.21 kB 0 B
packages/apps/esm-offline-tools-app/dist/78.js 6.15 kB +26 B (0%)
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/807.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/833.js 1.23 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 175 kB +479 B (0%)
packages/apps/esm-offline-tools-app/dist/937.js 6.61 kB +50 B (+1%)
packages/apps/esm-offline-tools-app/dist/967.js 0 B -492 B (removed) 🏆
packages/apps/esm-offline-tools-app/dist/main.js 56.8 kB -2.61 kB (-4%)
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.25 kB +1 B (0%)
packages/apps/esm-primary-navigation-app/dist/241.js 13.9 kB +65 B (0%)
packages/apps/esm-primary-navigation-app/dist/263.js 6.66 kB 0 B
packages/apps/esm-primary-navigation-app/dist/319.js 183 B 0 B
packages/apps/esm-primary-navigation-app/dist/414.js 0 B -467 B (removed) 🏆
packages/apps/esm-primary-navigation-app/dist/574.js 183 B 0 B
packages/apps/esm-primary-navigation-app/dist/575.js 441 B 0 B
packages/apps/esm-primary-navigation-app/dist/625.js 184 B 0 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-primary-navigation-app/dist/631.js 0 B -1.07 kB (removed) 🏆
packages/apps/esm-primary-navigation-app/dist/674.js 680 B 0 B
packages/apps/esm-primary-navigation-app/dist/710.js 6.44 kB 0 B
packages/apps/esm-primary-navigation-app/dist/716.js 6.12 kB +32 B (+1%)
packages/apps/esm-primary-navigation-app/dist/735.js 2.64 kB 0 B
packages/apps/esm-primary-navigation-app/dist/743.js 7.25 kB +31 B (0%)
packages/apps/esm-primary-navigation-app/dist/757.js 209 B 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/807.js 182 B 0 B
packages/apps/esm-primary-navigation-app/dist/833.js 210 B 0 B
packages/apps/esm-primary-navigation-app/dist/889.js 175 kB +478 B (0%)
packages/apps/esm-primary-navigation-app/dist/948.js 3.07 kB +1 B (0%)
packages/apps/esm-primary-navigation-app/dist/953.js 12.8 kB 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 4.78 kB +1 B (0%)
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.29 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 9.68 kB 0 B
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 2.66 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB 0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.12 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 894 B 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.05 kB 0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.67 kB 0 B
packages/framework/esm-framework/dist/146.openmrs-esm-framework.js 6.69 kB 0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.92 kB 0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.31 kB 0 B
packages/framework/esm-framework/dist/710.openmrs-esm-framework.js 6.48 kB 0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.66 kB 0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB 0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js 354 kB -694 B (0%)
packages/framework/esm-globals/dist/openmrs-esm-globals.js 714 B 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 18.5 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 888 B 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 82.6 kB +412 B (+1%)
packages/framework/esm-utils/dist/openmrs-esm-utils.js 10.2 kB 0 B
packages/shell/esm-app-shell/dist/17e03a23526ae1ec.js 0 B -1.58 kB (removed) 🏆
packages/shell/esm-app-shell/dist/a5f433e850eb73aa.js 6.04 kB 0 B
packages/shell/esm-app-shell/dist/e861b352d93d75e6.js 9.88 kB 0 B
packages/shell/esm-app-shell/dist/service-worker.js 57.3 kB +4 B (0%)
packages/tooling/openmrs/dist/cli.js 3.08 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 2.73 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 1.61 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 579 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 1.84 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 438 B 0 B
packages/tooling/openmrs/dist/commands/start.js 848 B 0 B
packages/tooling/openmrs/dist/index.js 517 B 0 B
packages/tooling/openmrs/dist/runner.js 870 B 0 B
packages/tooling/openmrs/dist/utils/config.js 726 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 639 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 393 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 3.25 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 444 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 234 B 0 B
packages/tooling/openmrs/dist/utils/npmConfig.js 854 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 721 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B 0 B
packages/tooling/webpack-config/dist/index.js 3.24 kB 0 B
packages/apps/esm-offline-tools-app/dist/297.js 466 B +466 B (new file) 🆕
packages/apps/esm-offline-tools-app/dist/696.js 410 B +410 B (new file) 🆕
packages/shell/esm-app-shell/dist/972cf9cf70317f32.js 1.58 kB +1.58 kB (new file) 🆕

compressed-size-action

@denniskigen denniskigen marked this pull request as draft September 14, 2023 19:34
@denniskigen denniskigen marked this pull request as ready for review September 21, 2023 12:17
@denniskigen denniskigen merged commit 16a992b into main Sep 24, 2023
7 checks passed
@denniskigen denniskigen deleted the chore/bump-carbon-deps branch September 24, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

@vasharma05 vasharma05 Awaiting requested review from vasharma05

@brandones brandones Awaiting requested review from brandones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@denniskigen @ibacher