(feat) Use SWR as a shared library #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
force-pushed
the
feat/shared-swr-cache
branch
from
b79b8c4
to
2fdd911
Compare
|
Size Change: -2.08 MB (-43%) 🎉 Total Size: 2.79 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
Sep 27, 2023
|
Wow. Awesome work, Ian. Thanks so much for taking this on. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
So these should be the code changes necessary to load SWR as a ModuleFederation shared. Using SWR this way is hard due to two glaring bugs, specifically webpack/webpack#16125 and vercel/swr#2356.
In essence the way this works is just what's suggested in webpack/webpack#16125, specifically, only the SWR sub-modules are actually marked as webpack shares while SWR core itself is not. However, because of how SWR's internals works, this actually works (i.e., the cache is shared across apps).
This PR also does the following:
${openmrsSpaBase}loginor${openmrsSpaBase}logout.nextlinks instead of sending a new request. This should be more efficient.Once this is merged, for packages that we want to use the shared SWR cache (which should be most of them), we need to update the version of
openmrsand addswrto the peer dependencies.Screenshots
Related Issue
Other