(fix) Locale switcher should default to user's defaultLocale or the session locale #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
force-pushed
the
fix/locale-switcher
branch
from
f47b707
to
e1f257c
Compare
|
Size Change: -2.23 MB (-44%) 🎉 Total Size: 2.84 MB
ℹ️ View Unchanged
|
|
Hi @ibacher @denniskigen , looking forward for your review. |
ibacher
reviewed
Oct 17, 2023
| }, | ||
| ac | ||
| ); | ||
| postSessionLocale(newLocale, ac); |
There was a problem hiding this comment.
We'd still want to change the session locale if only that value changed, right?
There was a problem hiding this comment.
What do you recommend?
...esm-primary-navigation-app/src/components/navbar-header-panels/user-menu-panel.component.tsx
Show resolved
Hide resolved
…aultLocale in user properties on change
|
As I checked @ibacher , after updating the user prop defaultLocale, the session locale was the same as the defaultLocale. So, the session locale, which is same as the user defaultLocale, can be considered as a source of truth. I'll put a recording of the same. |
|
I guess if it works, that's great. Saves us a network request. Basically, as long as we're always reading the session locale, it should be fine. |
|
Hi @ibacher @denniskigen ! |
ibacher
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Continuation to #757
The locale switcher was getting the session properties from the props, but props no props were passed into the component.
Screenshots
Before: Selected language is
enbut it showsaminstead.Related Issue
Other