(feat) Adds support for non-Gregorian calendars, with special work-arounds for Amharic #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounds for Amharic
|
cc: @amn-icap @gracepotma This is my proposal for a better way of achieving the goal of #786. |
|
Size Change: -2.09 MB (-41%) 🎉 Total Size: 2.99 MB
ℹ️ View Unchanged
|
|
Wow - bravo Ian for pushing this through, and so fast. CC @aman-icap |
4 tasks
denniskigen
reviewed
Oct 18, 2023
denniskigen
reviewed
Oct 18, 2023
ebambo
reviewed
Oct 24, 2023
| // Custom formatting for English. Use hyphens instead of spaces. | ||
| localeString = localeString.replace(/ /g, "-"); | ||
|
|
||
| if (_locale.language === "am") { |
There was a problem hiding this comment.
@ibacher why do we need to keep the month names in English? Wouldn't it better to keep them in Amharic ? What do you think @aman-icap
There was a problem hiding this comment.
I did this because I was trying to keep this PR in line with the functionality in #786, which also uses English names for months in Amharic. I mentioned that in the PR description. My preference would be to not have that hack at all.
|
Any updates here? @ebambo |
|
In the absence of any updates, approvals, etc. I'm just going to merge this in as it should be harmless for existing use-cases. Future work needed here can be addressed as additional tickets. |
|
Update from Dagim: the ICAP-Eth team is testing the work done on this branch and recommended we disregard the other/original #786 PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Basically, this has the same intention as #786, but with a somewhat cleaner implementation, utilising the standard JS library. It also adds support for registering default custom calendars on a per-locale basis, which is currently only used to use the Ethiopian calendar when the locale is Amharic.
See the added tests for some of what this PR allows.
Screenshots
Related Issue
Other
There's a hack in here I don't love: if the locale is set to Amharic, we format the date in English, but using the Ethiopic calendar, but this was done to produce the same results as #786.
#786 also basically stops the display of time strings, but this is a configurable option for the call to
formatDate(), and we should probably have a mechanism to handle the implementation-specific defaults rather than just relying on the workaround of having a separate formatter that doesn't display time in some circumstances.